From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: arch/mips/mm/tlbex.c:2243:3: warning: unannotated fall-through between switch labels
Date: Tue, 23 Nov 2021 12:16:48 -0600 [thread overview]
Message-ID: <20211123181648.GA9405@embeddedor> (raw)
In-Reply-To: <7b6e9af20d5e18315986c8e004a13c3840afb9ad.camel@perches.com>
On Tue, Nov 23, 2021 at 09:59:58AM -0800, Joe Perches wrote:
> On Tue, 2021-11-23 at 11:56 -0600, Gustavo A. R. Silva wrote:
> > On Tue, Nov 23, 2021 at 09:25:17AM -0800, Joe Perches wrote:
> > > On Tue, 2021-11-23 at 10:50 -0600, Gustavo A. R. Silva wrote:
> > > > On Tue, Nov 23, 2021 at 12:52:30AM -0800, Joe Perches wrote:
> > > > >
> > > > > Perhaps this would be better:
> > > >
> > > > Feel free to send a proper patch.
> > >
> > > I commented on your proposed patch.
> >
> > And I reply giving you an option if you want to proceed.
> >
> > > And I'd prefer you actually look at and improve the code instead
> > > of merely silencing warnings.
> >
> > If this is a matter of preference then I should express my preferences, too.
> > So, I prefer to give you the opportunity of improving the code and not being
> > pedantic at the same time. :)
>
> It appears to be difficult to give you suggestions on how to improve
> what you do.
No; that's appreciated.
What I suggest you to improve is how you communicate it, and to take
into account a "Feel free to send a proper patch."
Thanks
--
Gustavo
next prev parent reply other threads:[~2021-11-23 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 23:51 arch/mips/mm/tlbex.c:2243:3: warning: unannotated fall-through between switch labels kernel test robot
2021-11-23 0:55 ` Gustavo A. R. Silva
2021-11-23 8:52 ` Joe Perches
2021-11-23 16:50 ` Gustavo A. R. Silva
2021-11-23 17:25 ` Joe Perches
2021-11-23 17:56 ` Gustavo A. R. Silva
2021-11-23 17:59 ` Joe Perches
2021-11-23 18:16 ` Gustavo A. R. Silva [this message]
2021-11-23 18:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123181648.GA9405@embeddedor \
--to=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox