From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614FBC433EF for ; Wed, 24 Nov 2021 00:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240612AbhKXAPr (ORCPT ); Tue, 23 Nov 2021 19:15:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240590AbhKXAPp (ORCPT ); Tue, 23 Nov 2021 19:15:45 -0500 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6344C061714 for ; Tue, 23 Nov 2021 16:12:36 -0800 (PST) Received: by mail-pg1-x549.google.com with SMTP id a26-20020a63bd1a000000b002fab31bc2d9so95893pgf.7 for ; Tue, 23 Nov 2021 16:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=yN9AxgVhP403euh96vyR/P6B46ndFdybNrT4U7XWKGA=; b=O9McHgH/Odph1UfwBgVrusQu4D4wnX0ek4cbT2T05joLVmnA9D62D9n+LmfYeEb5/Z FYICZZWKu72FKhzHlImtfy4+Vz05Bda+Mq2y7IgUgzfuAWOWwG2h9fyouPPxKiw71Tai 6pMC42SYZW3JLNKU9PY8K37ldxYRgX6y9J6M0jr5eYS5+IEmN6ClFLR3MmDSyjQuEyvY 18E+HZBBHHeM3ah2hcrWlQYvMKHN29yZNbJXU9Kgxbx2r8bO/M88siQZbsH7YQBAUUjm 6nfL0PHuD4t0NRd/JfqU7QBaGIWNeC4ti8K+LMDpzN13Iu/P2H5qZ1voKJ0+gTn6c/yV D9tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=yN9AxgVhP403euh96vyR/P6B46ndFdybNrT4U7XWKGA=; b=CA77It55dhWEW1USl43+EZJ+hwSatDkdfIxgJs6UDfQkcHnY+0r0hZtO617CAcd5xd rxpahcekQYCQDtN+mfdrOVa/SDRf8UW0YrDc22Vi/hh9NarHgwWup4EbPNRNbqXPfi/d eJh7xfbvjkHemPqYNHMkbceLJF8BRYNAsTpHO7qGHT2QYzC92JwWXEUejd40X9hYFQMP v8P889M7DB6iUbES0YM6rpyvjW3BOANu3SoLFcwXMbhCGpAxQwjRzbKrLlHFeUgGg5PL 1J4IDCbZ7GYmUbTWSkkqvDT7PnA4OzV4tXKvI8Z3T0mRQqov9OWNarUBdmQX/Rj4Fhwp 5hIg== X-Gm-Message-State: AOAM533OCKg/rb9ZqOdr/1JuTy37DVGwdPuaiapX0GqtBCgTvIKrgfpC IzBaDceBU88mtnDuR7XeZJYSwzvZYRll X-Google-Smtp-Source: ABdhPJzNEuRRRYrc29XxGDMCWIspDpqFXUsZC0T1lx1Ih2r01Z7AkyiJfWQCCAEP165v2BXeYTAglRSi+vpZ X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:dbab:a6fe:1e3a:91fa]) (user=irogers job=sendgmr) by 2002:a17:90b:1486:: with SMTP id js6mr92355pjb.0.1637712756019; Tue, 23 Nov 2021 16:12:36 -0800 (PST) Date: Tue, 23 Nov 2021 16:12:29 -0800 In-Reply-To: <20211124001231.3277836-1-irogers@google.com> Message-Id: <20211124001231.3277836-2-irogers@google.com> Mime-Version: 1.0 References: <20211124001231.3277836-1-irogers@google.com> X-Mailer: git-send-email 2.34.0.rc2.393.gf8c9666880-goog Subject: [PATCH v2 2/4] perf tools: Fix SMT not detected From: Ian Rogers To: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Konstantin Khlebnikov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: eranian@google.com, Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sysfs__read_int returns 0 on success, and so the fast read path was always failing. Fixes: bb629484d924 (perf tools: Simplify checking if SMT is active.) Signed-off-by: Ian Rogers --- tools/perf/util/smt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/smt.c b/tools/perf/util/smt.c index 20bacd5972ad..34f1b1b1176c 100644 --- a/tools/perf/util/smt.c +++ b/tools/perf/util/smt.c @@ -15,7 +15,7 @@ int smt_on(void) if (cached) return cached_result; - if (sysfs__read_int("devices/system/cpu/smt/active", &cached_result) > 0) + if (sysfs__read_int("devices/system/cpu/smt/active", &cached_result) >= 0) goto done; ncpu = sysconf(_SC_NPROCESSORS_CONF); -- 2.34.0.rc2.393.gf8c9666880-goog