From: Jason Gunthorpe <jgg@nvidia.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: bharat@chelsio.com, dledford@redhat.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/3] Cleanup and optimize a few bitmap operations
Date: Thu, 25 Nov 2021 13:30:53 -0400 [thread overview]
Message-ID: <20211125173053.GB499138@nvidia.com> (raw)
In-Reply-To: <cover.1637789139.git.christophe.jaillet@wanadoo.fr>
On Wed, Nov 24, 2021 at 10:30:08PM +0100, Christophe JAILLET wrote:
> Patch 1 and 2 are just cleanups that uses 'bitmap_zalloc()' and 'bitmap_set()'
> instead of hand-writing these functions.
>
> Patch 3 is more questionable. It replaces calls to '[set|clear]_bit()' by their
> non-atomic '__[set|clear]_bit()' alternatives.
> It looks safe to do so because accesses to the corresponding bitmaps are
> protected by spinlocks.
> However, this patch is compile-tested only. It is not sure that it worth
> changing the code just for saving a few atomic operations.
> So review, test and apply only if it make sense.
>
> Christophe JAILLET (3):
> RDMA/cxgb4: Use bitmap_zalloc() when applicable
> RDMA/cxgb4: Use bitmap_set() when applicable
> RDMA/cxgb4: Use non-atomic bitmap functions when possible
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2021-11-25 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 21:30 [PATCH 0/3] Cleanup and optimize a few bitmap operations Christophe JAILLET
2021-11-24 21:40 ` [PATCH 1/3] RDMA/cxgb4: Use bitmap_zalloc() when applicable Christophe JAILLET
2021-11-24 21:40 ` [PATCH 2/3] RDMA/cxgb4: Use bitmap_set() " Christophe JAILLET
2021-11-24 21:40 ` [PATCH 3/3] RDMA/cxgb4: Use non-atomic bitmap functions when possible Christophe JAILLET
2021-11-25 17:30 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211125173053.GB499138@nvidia.com \
--to=jgg@nvidia.com \
--cc=bharat@chelsio.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dledford@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox