From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91564C4332F for ; Fri, 26 Nov 2021 02:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358918AbhKZCpV (ORCPT ); Thu, 25 Nov 2021 21:45:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:50268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358494AbhKZClZ (ORCPT ); Thu, 25 Nov 2021 21:41:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BFF4E6124C; Fri, 26 Nov 2021 02:34:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637894090; bh=5TwPh6Xbe+N736CO1QPweO1XgFLhSjELyl+FGv8OlDE=; h=From:To:Cc:Subject:Date:From; b=BZn6XuW+DrrasHsGwhkrFnzbZgz/+fg3gAcKz3hsNZTJVO/s7yXKzDi1CHYIbixtp 5FDxY/HjbhvQJ6KwRHXTEPIqGozVPGXighJwWx8AOOxMnq6Ma+Ovtbuu5TcNzY8AnF cpHTIQr1QP6UwbO5U050Ic7AVTyvaYSeosmkchKn0tCFofpizkczmjzd1ewKJEDLYU WA5+6/EFqtbEdfIXKUtigpL/XTZP7aUqtnl+Y4Tspi/NlEj/VMmEPC37fYuCM9SvYc i6bwHOafU7mJg+7LilorW+c07dMLcQa57PsYPG9qc94ss8NLk304JYRkSD+4NDwXHH mdEBY8tJqBung== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andreas Gruenbacher , Sasha Levin , rpeterso@redhat.com, cluster-devel@redhat.com Subject: [PATCH AUTOSEL 5.4 01/19] gfs2: Fix length of holes reported at end-of-file Date: Thu, 25 Nov 2021 21:34:30 -0500 Message-Id: <20211126023448.442529-1-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andreas Gruenbacher [ Upstream commit f3506eee81d1f700d9ee2d2f4a88fddb669ec032 ] Fix the length of holes reported at the end of a file: the length is relative to the beginning of the extent, not the seek position which is rounded down to the filesystem block size. This bug went unnoticed for some time, but is now caught by the following assertion in iomap_iter_done(): WARN_ON_ONCE(iter->iomap.offset + iter->iomap.length <= iter->pos) Signed-off-by: Andreas Gruenbacher Signed-off-by: Sasha Levin --- fs/gfs2/bmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index aaec3c5b02028..dec5285a02e9d 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -940,7 +940,7 @@ static int gfs2_iomap_get(struct inode *inode, loff_t pos, loff_t length, else if (height == ip->i_height) ret = gfs2_hole_size(inode, lblock, len, mp, iomap); else - iomap->length = size - pos; + iomap->length = size - iomap->offset; } else if (flags & IOMAP_WRITE) { u64 alloc_size; -- 2.33.0