From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
Date: Mon, 29 Nov 2021 10:53:14 +0300 [thread overview]
Message-ID: <20211129075314.GP18178@kadam> (raw)
In-Reply-To: <0b6aec80835439afe62010a4228fc1af49f68e2b.camel@codeconstruct.com.au>
On Mon, Nov 29, 2021 at 10:24:15AM +0800, Jeremy Kerr wrote:
> Hi Dan,
>
> > smatch warnings:
> > net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
>
> Thanks for the report! I've sent a fix, you're CCed.
>
> However, I can 't seem to recreate the smatch warning; could you include
> the build command you're using for these? I've tried with
>
> make [...] C=1 CHECK=/path/to/smatch
The CHECK= string needs a -p=kernel added to it or it won't do kernel
specific checking.
make [...] C=1 CHECK="/path/to/smatch -p=kernel"
regards,
dan carpenter
prev parent reply other threads:[~2021-11-29 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 7:05 net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb) Dan Carpenter
2021-11-29 2:24 ` Jeremy Kerr
2021-11-29 7:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129075314.GP18178@kadam \
--to=dan.carpenter@oracle.com \
--cc=jk@codeconstruct.com.au \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox