From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30557C433F5 for ; Tue, 30 Nov 2021 14:55:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243733AbhK3O61 (ORCPT ); Tue, 30 Nov 2021 09:58:27 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:48072 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232187AbhK3Ozr (ORCPT ); Tue, 30 Nov 2021 09:55:47 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 83BBDB81A5F; Tue, 30 Nov 2021 14:52:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80A7BC8D180; Tue, 30 Nov 2021 14:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638283945; bh=A4f6DIUx4t28wWw6o3+t5fELurv1o9rgYYTfIMlw3NE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BCiQmFHLs3HZe98fcv0P9ZexAoumZzuPmxxx11kWEiAqU9rLZFNsGLN1aTioFRAlX dOrUIGOTfOEcxvZrO+C1WEfRA8ssswM7XjidByZt7LrbK+jFhHPuU+AQyWKUt1HgnW ySr0Rich0UeBFzAdfifWnhvqxNTvyA6tYb7jsA4VqlNeqY82K7ZzNDXYmLvD/+4mMS wCw4Cy9cr5477LLwcRWLXifzJSXbL4PqghN3ZPo7F38KE8cWhDdWGmwCPwD1GkGnMV wI6WPNYne4J8u6RJEnloQGnCj0Ya55cMu3F1OdpXPaRF7fg+Yx3jvQUzuCPI827y/b bvmC7vW9qC3qQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , "David S . Miller" , Sasha Levin , rajur@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 14/25] net: chelsio: cxgb4vf: Fix an error code in cxgb4vf_pci_probe() Date: Tue, 30 Nov 2021 09:51:44 -0500 Message-Id: <20211130145156.946083-14-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211130145156.946083-1-sashal@kernel.org> References: <20211130145156.946083-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheyu Ma [ Upstream commit b82d71c0f84a2e5ccaaa7571dfd5c69e0e2cfb4a ] During the process of driver probing, probe function should return < 0 for failure, otherwise kernel will treat value == 0 as success. Therefore, we should set err to -EINVAL when adapter->registered_device_map is NULL. Otherwise kernel will assume that driver has been successfully probed and will cause unexpected errors. Signed-off-by: Zheyu Ma Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c index f4d41f968afa2..fb747901462e0 100644 --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c @@ -3246,6 +3246,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev, } if (adapter->registered_device_map == 0) { dev_err(&pdev->dev, "could not register any net devices\n"); + err = -EINVAL; goto err_disable_interrupts; } -- 2.33.0