public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Evan Green <evgreen@chromium.org>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Sasha Levin <sashal@kernel.org>,
	rafael@kernel.org, pavel@ucw.cz, len.brown@intel.com,
	linux-pm@vger.kernel.org
Subject: [PATCH AUTOSEL 4.4 7/9] PM: hibernate: Fix snapshot partial write lengths
Date: Tue, 30 Nov 2021 09:54:00 -0500	[thread overview]
Message-ID: <20211130145402.947049-7-sashal@kernel.org> (raw)
In-Reply-To: <20211130145402.947049-1-sashal@kernel.org>

From: Evan Green <evgreen@chromium.org>

[ Upstream commit 88a5045f176b78c33a269a30a7b146e99c550bd9 ]

snapshot_write() is inappropriately limiting the amount of data that can
be written in cases where a partial page has already been written. For
example, one would expect to be able to write 1 byte, then 4095 bytes to
the snapshot device, and have both of those complete fully (since now
we're aligned to a page again). But what ends up happening is we write 1
byte, then 4094/4095 bytes complete successfully.

The reason is that simple_write_to_buffer()'s second argument is the
total size of the buffer, not the size of the buffer minus the offset.
Since simple_write_to_buffer() accounts for the offset in its
implementation, snapshot_write() can just pass the full page size
directly down.

Signed-off-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 kernel/power/user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/user.c b/kernel/power/user.c
index f83c1876b39c0..67659e507747e 100644
--- a/kernel/power/user.c
+++ b/kernel/power/user.c
@@ -181,7 +181,7 @@ static ssize_t snapshot_write(struct file *filp, const char __user *buf,
 		if (res <= 0)
 			goto unlock;
 	} else {
-		res = PAGE_SIZE - pg_offp;
+		res = PAGE_SIZE;
 	}
 
 	if (!data_of(data->handle)) {
-- 
2.33.0


  parent reply	other threads:[~2021-11-30 15:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 14:53 [PATCH AUTOSEL 4.4 1/9] xen/privcmd: make option visible in Kconfig Sasha Levin
2021-11-30 14:53 ` [PATCH AUTOSEL 4.4 2/9] NFSv4.1: handle NFS4ERR_NOSPC by CREATE_SESSION Sasha Levin
2021-11-30 14:53 ` [PATCH AUTOSEL 4.4 3/9] HID: multitouch: Fix Iiyama ProLite T1931SAW (0eef:0001 again!) Sasha Levin
2021-11-30 14:53 ` [PATCH AUTOSEL 4.4 4/9] parisc: Provide an extru_safe() macro to extract unsigned bits Sasha Levin
2021-12-04 12:15   ` Pavel Machek
2021-12-04 14:57     ` Helge Deller
2021-11-30 14:53 ` [PATCH AUTOSEL 4.4 5/9] mmc: spi: Add device-tree SPI IDs Sasha Levin
2021-11-30 14:53 ` [PATCH AUTOSEL 4.4 6/9] smb2: clarify rc initialization in smb2_reconnect Sasha Levin
2021-11-30 14:54 ` Sasha Levin [this message]
2021-11-30 14:54 ` [PATCH AUTOSEL 4.4 8/9] net: ptp: add a definition for the UDP port for IEEE 1588 general messages Sasha Levin
2021-12-04 12:18   ` Pavel Machek
2021-11-30 14:54 ` [PATCH AUTOSEL 4.4 9/9] fs: ntfs: Limit NTFS_RW to page sizes smaller than 64k Sasha Levin
2021-12-04 12:23   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130145402.947049-7-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=evgreen@chromium.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox