Re: [PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers

Thierry Reding
2021-12-16T13:00:06Z

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

On Wed, Dec 01, 2021 at 02:23:36AM +0300, Dmitry Osipenko wrote:
> Use resource-managed helpers to make code cleaner and more correct,
> properly releasing all resources in case of driver probe error.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/soc/tegra/fuse/fuse-tegra.c | 32 ++++++++++++++------------
> drivers/soc/tegra/fuse/fuse-tegra20.c | 33 ++++++++++++++++++++++++---
> 2 files changed, 48 insertions(+), 17 deletions(-)

Ehm... this is very borderline. Adding 31 lines of code isn't exactly
making the code cleaner.

On the other hand I don't care enough to get into an argument, so I've
applied this anyway.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]