From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Camel Guo <Camel.Guo@axis.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
kernel <kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: rs5c372: add offset correction support
Date: Wed, 1 Dec 2021 09:43:02 +0100 [thread overview]
Message-ID: <20211201084302.GA26222@axis.com> (raw)
In-Reply-To: <f0e2eb3c-8e50-f6db-4c52-810da9c83b7a@axis.com>
On Tue, Nov 30, 2021 at 03:55:43PM +0100, Camel Guo wrote:
> Just realize that the oscillation adjustment registers of r2*, rs5c* are
> not totally same and all of these differences need to be handled in
> different way. Hence this patch needs to be updated to cover all cases.
Unless you have the hardware to actually test the other variants,
perhaps it would be safer to just reject them in ->set_offset /
->get_offset for now? Returning -EINVAL for unsupported types should
make rtc_set_offset() and rtc_get_offset() have the same behaviour as
not implementing the callbacks for these variants.
next prev parent reply other threads:[~2021-12-01 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 9:50 [PATCH] rtc: rs5c372: add offset correction support Camel Guo
2021-11-30 14:55 ` Camel Guo
2021-12-01 8:43 ` Vincent Whitchurch [this message]
2021-12-02 15:25 ` Camel Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201084302.GA26222@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=Camel.Guo@axis.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox