From: Corey Minyard <minyard@acm.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi/watchdog: Constify ident
Date: Wed, 1 Dec 2021 13:42:17 -0600 [thread overview]
Message-ID: <20211201194217.GI15676@minyard.net> (raw)
In-Reply-To: <20211128220154.32927-1-rikard.falkeborn@gmail.com>
On Sun, Nov 28, 2021 at 11:01:54PM +0100, Rikard Falkeborn wrote:
> ident is not modified and can be made const to allow the compiler to put
> it in read-only memory.
In my queue for next release. Thanks.
-corey
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 883b4a341012..0604abdd249a 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -668,7 +668,7 @@ static int ipmi_heartbeat(void)
> return rv;
> }
>
> -static struct watchdog_info ident = {
> +static const struct watchdog_info ident = {
> .options = 0, /* WDIOF_SETTIMEOUT, */
> .firmware_version = 1,
> .identity = "IPMI"
> --
> 2.34.1
>
prev parent reply other threads:[~2021-12-01 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 22:01 [PATCH] ipmi/watchdog: Constify ident Rikard Falkeborn
2021-12-01 19:42 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201194217.GI15676@minyard.net \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox