* [PATCH] ipmi/watchdog: Constify ident
@ 2021-11-28 22:01 Rikard Falkeborn
2021-12-01 19:42 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Rikard Falkeborn @ 2021-11-28 22:01 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-kernel, Rikard Falkeborn
ident is not modified and can be made const to allow the compiler to put
it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/char/ipmi/ipmi_watchdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 883b4a341012..0604abdd249a 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -668,7 +668,7 @@ static int ipmi_heartbeat(void)
return rv;
}
-static struct watchdog_info ident = {
+static const struct watchdog_info ident = {
.options = 0, /* WDIOF_SETTIMEOUT, */
.firmware_version = 1,
.identity = "IPMI"
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi/watchdog: Constify ident
2021-11-28 22:01 [PATCH] ipmi/watchdog: Constify ident Rikard Falkeborn
@ 2021-12-01 19:42 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2021-12-01 19:42 UTC (permalink / raw)
To: Rikard Falkeborn; +Cc: openipmi-developer, linux-kernel
On Sun, Nov 28, 2021 at 11:01:54PM +0100, Rikard Falkeborn wrote:
> ident is not modified and can be made const to allow the compiler to put
> it in read-only memory.
In my queue for next release. Thanks.
-corey
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 883b4a341012..0604abdd249a 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -668,7 +668,7 @@ static int ipmi_heartbeat(void)
> return rv;
> }
>
> -static struct watchdog_info ident = {
> +static const struct watchdog_info ident = {
> .options = 0, /* WDIOF_SETTIMEOUT, */
> .firmware_version = 1,
> .identity = "IPMI"
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-01 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-28 22:01 [PATCH] ipmi/watchdog: Constify ident Rikard Falkeborn
2021-12-01 19:42 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox