From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Sam Protsenko <semen.protsenko@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>,
Chanwoo Choi <cw00.choi@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Mike Tipton <mdtipton@codeaurora.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v6] clk: Add write operation for clk_parent debugfs node
Date: Wed, 01 Dec 2021 12:52:05 -0800 [thread overview]
Message-ID: <20211201205206.BD5AFC53FD3@smtp.kernel.org> (raw)
In-Reply-To: <CAEG3pNCxuPNwqvRWnMuFNMmiV0nZRwC+1M69jVC=uMyS5Jie6Q@mail.gmail.com>
Quoting Michael Turquette (2021-11-23 09:43:55)
> On Mon, Nov 22, 2021 at 10:03 AM Sam Protsenko
> <semen.protsenko@linaro.org> wrote:
> >
> > On Tue, 19 Oct 2021 at 16:32, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> > >
> > > On Wed, 13 Oct 2021 at 21:04, Fabio Estevam <festevam@gmail.com> wrote:
> > > >
> > > > Hi Sam,
> > > >
> > > > On Wed, Oct 13, 2021 at 2:20 PM Sam Protsenko
> > > > <semen.protsenko@linaro.org> wrote:
> > > > >
> > > > > Useful for testing mux clocks. One can write the index of the parent to
> > > > > be set into clk_parent node, starting from 0. Example
> > > > >
> > > > > # cd /sys/kernel/debug/clk/mout_peri_bus
> > > > > # cat clk_possible_parents
> > > > > dout_shared0_div4 dout_shared1_div4
> > > > > # cat clk_parent
> > > > > dout_shared0_div4
> > > > > # echo 1 > clk_parent
> > > > > # cat clk_parent
> > > > > dout_shared1_div4
> > > > >
> > > > > CLOCK_ALLOW_WRITE_DEBUGFS has to be defined in drivers/clk/clk.c in
> > > > > order to use this feature.
> > > > >
> > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > This is useful, thanks:
> > > >
> > > > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > >
> > > Hi Michael, Stephen,
> > >
> > > If there are no outstanding comments, can you please take this one?
> > >
> >
> > Bump.
>
> Looks good to me.
>
> Acked-by: Michael Turquette <mturquette@baylibre.com>
>
> Stephen, can you take it into your tree?
Sure thing.
next prev parent reply other threads:[~2021-12-01 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 17:20 [PATCH v6] clk: Add write operation for clk_parent debugfs node Sam Protsenko
2021-10-13 18:04 ` Fabio Estevam
2021-10-19 13:32 ` Sam Protsenko
2021-11-22 16:03 ` Sam Protsenko
2021-11-23 17:43 ` Michael Turquette
2021-12-01 20:09 ` Sam Protsenko
2021-12-01 20:52 ` Stephen Boyd [this message]
2021-12-10 1:17 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201205206.BD5AFC53FD3@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mdtipton@codeaurora.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox