From: Andrew Morton <akpm@linux-foundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] panic: Remove oops_id.
Date: Thu, 2 Dec 2021 14:43:08 -0800 [thread overview]
Message-ID: <20211202144308.70fd454883c1d1e643491471@linux-foundation.org> (raw)
In-Reply-To: <20211202142713.ofadr43tawengfw4@linutronix.de>
On Thu, 2 Dec 2021 15:27:13 +0100 Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> The oops id has been added as part of the end of trace marker for the
> kerneloops.org project. The id is used to automatically identify duplicate
> submissions of the same report. Identical looking reports with different
> a id can be considered as the same oops occurred again.
>
> The early initialisation of the oops_id can create a warning if the
> random core is not yet fully initialized. On PREEMPT_RT it is
> problematic if the id is initialized on demand from non preemptible
> context.
"problematic" isn't very useful :(
What exactly goes wrong under -rt?
> The kernel oops project is not available since 2017.
> Remove the oops_id.
(googles "linux oops_id")
https://wiki.ubuntu.com/UbuntuWeeklyNewsletter/Issue565#What.2BIBk-s_the_OOPS_ID.3F
Seems someone was using it in 2019. My search was very brief.
The world wouldn't end if we removed this. But perhaps it would be better
to replace the oops id with "0" to avoid breaking parsers.
It's just a fairly unique number. We could use anything. Simply
jiffies or ktime_get() would suffice?
next prev parent reply other threads:[~2021-12-02 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 14:27 [PATCH] panic: Remove oops_id Sebastian Andrzej Siewior
2021-12-02 22:43 ` Andrew Morton [this message]
2021-12-03 13:14 ` Sebastian Andrzej Siewior
2021-12-13 15:12 ` [PATCH v2] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202144308.70fd454883c1d1e643491471@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox