From: Arnd Bergmann <arnd@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Wu Zongyong <wuzongyong@linux.alibaba.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>, Eli Cohen <elic@nvidia.com>,
Xie Yongji <xieyongji@bytedance.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] eni_vdpa: alibaba: select VIRTIO_PCI_LIB
Date: Fri, 3 Dec 2021 19:55:14 +0100 [thread overview]
Message-ID: <20211203185522.692489-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
When VIRTIO_PCI_LIB is not built-in but the alibaba driver is, the
kernel runs into a link error:
x86_64-linux-ld: drivers/vdpa/alibaba/eni_vdpa.o: in function `eni_vdpa_set_features':
eni_vdpa.c:(.text+0x23f): undefined reference to `vp_legacy_set_features'
x86_64-linux-ld: drivers/vdpa/alibaba/eni_vdpa.o: in function `eni_vdpa_set_vq_state':
eni_vdpa.c:(.text+0x2fe): undefined reference to `vp_legacy_get_queue_enable'
x86_64-linux-ld: drivers/vdpa/alibaba/eni_vdpa.o: in function `eni_vdpa_set_vq_address':
eni_vdpa.c:(.text+0x376): undefined reference to `vp_legacy_set_queue_address'
x86_64-linux-ld: drivers/vdpa/alibaba/eni_vdpa.o: in function `eni_vdpa_set_vq_ready':
eni_vdpa.c:(.text+0x3b4): undefined reference to `vp_legacy_set_queue_address'
x86_64-linux-ld: drivers/vdpa/alibaba/eni_vdpa.o: in function `eni_vdpa_free_irq':
eni_vdpa.c:(.text+0x460): undefined reference to `vp_legacy_queue_vector'
x86_64-linux-ld: eni_vdpa.c:(.text+0x4b7): undefined reference to `vp_legacy_config_vector'
x86_64-linux-ld: drivers/vdpa/alibaba/eni_vdpa.o: in function `eni_vdpa_reset':
Selecting VIRTIO_PCI_LIB_LEGACY is not sufficient here since that is
only part of the VIRTIO_PCI_LIB support.
Fixes: e85087beedca ("eni_vdpa: add vDPA driver for Alibaba ENI")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/vdpa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
index 50f45d037611..04466603021f 100644
--- a/drivers/vdpa/Kconfig
+++ b/drivers/vdpa/Kconfig
@@ -80,6 +80,7 @@ config VP_VDPA
config ALIBABA_ENI_VDPA
tristate "vDPA driver for Alibaba ENI"
+ select VIRTIO_PCI_LIB
select VIRTIO_PCI_LIB_LEGACY
depends on PCI_MSI && X86
help
--
2.29.2
next reply other threads:[~2021-12-03 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 18:55 Arnd Bergmann [this message]
2021-12-06 3:12 ` [PATCH] eni_vdpa: alibaba: select VIRTIO_PCI_LIB Jason Wang
2021-12-06 8:14 ` Arnd Bergmann
2021-12-06 8:41 ` Jason Wang
2021-12-08 19:56 ` Michael S. Tsirkin
2021-12-08 21:31 ` Arnd Bergmann
2021-12-08 22:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203185522.692489-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzongyong@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox