From: Arnd Bergmann <arnd@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Daniel J. Ogorchock" <djogorchock@gmail.com>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Roderick Colenbrander" <roderick.colenbrander@sony.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] HID: prodikeys: add USB_HID dependency
Date: Fri, 3 Dec 2021 19:59:01 +0100 [thread overview]
Message-ID: <20211203185928.821497-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Like with the other drivers that recently got fixed, this one
fails to link if USB_HID is disabled or unreachable:
ERROR: modpost: "usb_hid_driver" [drivers/hid/hid-prodikeys.ko] undefined!
Fixes: f237d9028f84 ("HID: add USB_HID dependancy on some USB HID drivers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 74ce789f8636..48d18559670f 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -246,7 +246,7 @@ config HID_MACALLY
config HID_PRODIKEYS
tristate "Prodikeys PC-MIDI Keyboard support"
- depends on HID && SND
+ depends on USB_HID && SND
select SND_RAWMIDI
help
Support for Prodikeys PC-MIDI Keyboard device support.
--
2.29.2
next reply other threads:[~2021-12-03 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 18:59 Arnd Bergmann [this message]
2021-12-06 7:44 ` [PATCH] HID: prodikeys: add USB_HID dependency Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203185928.821497-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox