From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346A5C433F5 for ; Mon, 6 Dec 2021 21:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350885AbhLFVTA (ORCPT ); Mon, 6 Dec 2021 16:19:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350677AbhLFVSg (ORCPT ); Mon, 6 Dec 2021 16:18:36 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38A95C0698E0; Mon, 6 Dec 2021 13:14:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8604ACE155A; Mon, 6 Dec 2021 21:14:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33FBEC341C1; Mon, 6 Dec 2021 21:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638825294; bh=pQE60b+PjcLVTwWbBbEUh82jS+EsMmj4rNuXKiHL/qY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EYf8yVwvjcLqutbM/MO7tCVNjUdcyWzX0UiV8v1abWVgoFnYJ+PvQiiSXhyW4baWP SCZUga0qpt6ccdYKvQCMh91a27/iXT0f0H8DVuwpDSeXnuNUFhRSRNwZoIy+nWILBx XuGGg2eNBYTSphwzyNoMdEITck2z/uEC7/iDxLKAGkzT9G69LEFbl23EFsy1W1WV6p p7YUziP+9XzN5+LT1kq7K6PprTxv9V1MwVMf5SpY9e6V7ezbQm8mpb0xaxXF/XBwcY EFNipwEakfuNttUAP6+GAnWDfzEfcc6xMMLsvIAnekZU1bV0fbJ4iImgdIEnLqn1Gd cfKKP5JhiaHZg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mustapha Ghaddar , Jun Lei , Bhawanpreet Lakha , Mustapha Ghaddar , Daniel Wheeler , Alex Deucher , Sasha Levin , harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch, aric.cyr@amd.com, Jimmy.Kizito@amd.com, mario.kleiner.de@gmail.com, nicholas.kazlauskas@amd.com, lee.jones@linaro.org, Dmytro.Laktyushkin@amd.com, Jerry.Zuo@amd.com, vladimir.stempen@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.15 19/24] drm/amd/display: Fix for the no Audio bug with Tiled Displays Date: Mon, 6 Dec 2021 16:12:24 -0500 Message-Id: <20211206211230.1660072-19-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211206211230.1660072-1-sashal@kernel.org> References: <20211206211230.1660072-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mustapha Ghaddar [ Upstream commit 5ceaebcda9061c04f439c93961f0819878365c0f ] [WHY] It seems like after a series of plug/unplugs we end up in a situation where tiled display doesnt support Audio. [HOW] The issue seems to be related to when we check streams changed after an HPD, we should be checking the audio_struct as well to see if any of its values changed. Reviewed-by: Jun Lei Acked-by: Bhawanpreet Lakha Signed-off-by: Mustapha Ghaddar Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c index a60396d5be445..e94546187cf15 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c @@ -1623,6 +1623,10 @@ bool dc_is_stream_unchanged( if (old_stream->ignore_msa_timing_param != stream->ignore_msa_timing_param) return false; + // Only Have Audio left to check whether it is same or not. This is a corner case for Tiled sinks + if (old_stream->audio_info.mode_count != stream->audio_info.mode_count) + return false; + return true; } -- 2.33.0