From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Mustapha Ghaddar <mghaddar@amd.com>, Jun Lei <Jun.Lei@amd.com>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Mustapha Ghaddar <mustapha.ghaddar@amd.com>,
Daniel Wheeler <daniel.wheeler@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sasha Levin <sashal@kernel.org>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
aric.cyr@amd.com, mario.kleiner.de@gmail.com,
Jimmy.Kizito@amd.com, liviu@dudau.co.uk, lee.jones@linaro.org,
Dmytro.Laktyushkin@amd.com, Jerry.Zuo@amd.com,
vladimir.stempen@amd.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 5.4 08/10] drm/amd/display: Fix for the no Audio bug with Tiled Displays
Date: Mon, 6 Dec 2021 16:17:27 -0500 [thread overview]
Message-ID: <20211206211738.1661003-8-sashal@kernel.org> (raw)
In-Reply-To: <20211206211738.1661003-1-sashal@kernel.org>
From: Mustapha Ghaddar <mghaddar@amd.com>
[ Upstream commit 5ceaebcda9061c04f439c93961f0819878365c0f ]
[WHY]
It seems like after a series of plug/unplugs we end up in a situation
where tiled display doesnt support Audio.
[HOW]
The issue seems to be related to when we check streams changed after an
HPD, we should be checking the audio_struct as well to see if any of its
values changed.
Reviewed-by: Jun Lei <Jun.Lei@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Mustapha Ghaddar <mustapha.ghaddar@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
index f25ac17f47fa9..95a5310e9e661 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
@@ -1546,6 +1546,10 @@ bool dc_is_stream_unchanged(
if (old_stream->ignore_msa_timing_param != stream->ignore_msa_timing_param)
return false;
+ // Only Have Audio left to check whether it is same or not. This is a corner case for Tiled sinks
+ if (old_stream->audio_info.mode_count != stream->audio_info.mode_count)
+ return false;
+
return true;
}
--
2.33.0
next prev parent reply other threads:[~2021-12-06 21:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 21:17 [PATCH AUTOSEL 5.4 01/10] drm/msm/dsi: set default num_data_lanes Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 02/10] USB: NO_LPM quirk Lenovo Powered USB-C Travel Hub Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 03/10] net/mlx4_en: Update reported link modes for 1/10G Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 04/10] tools: Fix math.h breakage Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 05/10] parisc/agp: Annotate parisc agp init functions with __init Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 06/10] i2c: rk3x: Handle a spurious start completion interrupt flag Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 07/10] net: netlink: af_netlink: Prevent empty skb by adding a check on len Sasha Levin
2021-12-06 21:17 ` Sasha Levin [this message]
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 09/10] drm/amd/display: add connector type check for CRC source set Sasha Levin
2021-12-06 21:17 ` [PATCH AUTOSEL 5.4 10/10] tracing: Fix a kmemleak false positive in tracing_map Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206211738.1661003-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=Jimmy.Kizito@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aric.cyr@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.wheeler@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu@dudau.co.uk \
--cc=mario.kleiner.de@gmail.com \
--cc=mghaddar@amd.com \
--cc=mustapha.ghaddar@amd.com \
--cc=stable@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=vladimir.stempen@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox