* [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1
@ 2021-11-30 21:20 Martin Botka
2021-12-03 1:03 ` Stephen Boyd
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Martin Botka @ 2021-11-30 21:20 UTC (permalink / raw)
To: martin.botka1
Cc: ~postmarketos/upstreaming, konrad.dybcio,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
paul.bouchara, Martin Botka, Andy Gross, Bjorn Andersson,
Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel
Without this change eMMC runs at overclocked freq.
Swap the ops to not OC the eMMC.
Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
drivers/clk/qcom/gcc-sm6125.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sm6125.c b/drivers/clk/qcom/gcc-sm6125.c
index 543cfab7561f..431b55bb0d2f 100644
--- a/drivers/clk/qcom/gcc-sm6125.c
+++ b/drivers/clk/qcom/gcc-sm6125.c
@@ -1121,7 +1121,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
.name = "gcc_sdcc1_apps_clk_src",
.parent_data = gcc_parent_data_1,
.num_parents = ARRAY_SIZE(gcc_parent_data_1),
- .ops = &clk_rcg2_ops,
+ .ops = &clk_rcg2_floor_ops,
},
};
@@ -1143,7 +1143,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
.name = "gcc_sdcc1_ice_core_clk_src",
.parent_data = gcc_parent_data_0,
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
- .ops = &clk_rcg2_floor_ops,
+ .ops = &clk_rcg2_ops,
},
};
--
2.34.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1
2021-11-30 21:20 [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1 Martin Botka
@ 2021-12-03 1:03 ` Stephen Boyd
2021-12-03 16:09 ` Bjorn Andersson
2021-12-06 22:41 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-12-03 1:03 UTC (permalink / raw)
To: Martin Botka, martin.botka1
Cc: ~postmarketos/upstreaming, konrad.dybcio,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
paul.bouchara, Martin Botka, Andy Gross, Bjorn Andersson,
Michael Turquette, linux-arm-msm, linux-clk, linux-kernel
Quoting Martin Botka (2021-11-30 13:20:15)
> Without this change eMMC runs at overclocked freq.
> Swap the ops to not OC the eMMC.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
Any Fixes tag?
> drivers/clk/qcom/gcc-sm6125.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6125.c b/drivers/clk/qcom/gcc-sm6125.c
> index 543cfab7561f..431b55bb0d2f 100644
> --- a/drivers/clk/qcom/gcc-sm6125.c
> +++ b/drivers/clk/qcom/gcc-sm6125.c
> @@ -1121,7 +1121,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
> .name = "gcc_sdcc1_apps_clk_src",
> .parent_data = gcc_parent_data_1,
> .num_parents = ARRAY_SIZE(gcc_parent_data_1),
> - .ops = &clk_rcg2_ops,
> + .ops = &clk_rcg2_floor_ops,
> },
> };
>
> @@ -1143,7 +1143,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
> .name = "gcc_sdcc1_ice_core_clk_src",
> .parent_data = gcc_parent_data_0,
> .num_parents = ARRAY_SIZE(gcc_parent_data_0),
> - .ops = &clk_rcg2_floor_ops,
> + .ops = &clk_rcg2_ops,
> },
> };
>
> --
> 2.34.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1
2021-11-30 21:20 [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1 Martin Botka
2021-12-03 1:03 ` Stephen Boyd
@ 2021-12-03 16:09 ` Bjorn Andersson
2021-12-06 22:41 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2021-12-03 16:09 UTC (permalink / raw)
To: Martin Botka
Cc: martin.botka1, ~postmarketos/upstreaming, konrad.dybcio,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
paul.bouchara, Andy Gross, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk, linux-kernel
On Tue 30 Nov 15:20 CST 2021, Martin Botka wrote:
> Without this change eMMC runs at overclocked freq.
> Swap the ops to not OC the eMMC.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
Fixes: 4b8d6ae57cdf ("clk: qcom: Add SM6125 (TRINKET) GCC driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/clk/qcom/gcc-sm6125.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6125.c b/drivers/clk/qcom/gcc-sm6125.c
> index 543cfab7561f..431b55bb0d2f 100644
> --- a/drivers/clk/qcom/gcc-sm6125.c
> +++ b/drivers/clk/qcom/gcc-sm6125.c
> @@ -1121,7 +1121,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
> .name = "gcc_sdcc1_apps_clk_src",
> .parent_data = gcc_parent_data_1,
> .num_parents = ARRAY_SIZE(gcc_parent_data_1),
> - .ops = &clk_rcg2_ops,
> + .ops = &clk_rcg2_floor_ops,
> },
> };
>
> @@ -1143,7 +1143,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
> .name = "gcc_sdcc1_ice_core_clk_src",
> .parent_data = gcc_parent_data_0,
> .num_parents = ARRAY_SIZE(gcc_parent_data_0),
> - .ops = &clk_rcg2_floor_ops,
> + .ops = &clk_rcg2_ops,
> },
> };
>
> --
> 2.34.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1
2021-11-30 21:20 [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1 Martin Botka
2021-12-03 1:03 ` Stephen Boyd
2021-12-03 16:09 ` Bjorn Andersson
@ 2021-12-06 22:41 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-12-06 22:41 UTC (permalink / raw)
To: Martin Botka, martin.botka1
Cc: ~postmarketos/upstreaming, konrad.dybcio,
angelogioacchino.delregno, marijn.suijten, jamipkettunen,
paul.bouchara, Martin Botka, Andy Gross, Bjorn Andersson,
Michael Turquette, linux-arm-msm, linux-clk, linux-kernel
Quoting Martin Botka (2021-11-30 13:20:15)
> Without this change eMMC runs at overclocked freq.
> Swap the ops to not OC the eMMC.
>
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-06 22:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-30 21:20 [PATCH] clk: qcom: sm6125-gcc: Swap ops of ice and apps on sdcc1 Martin Botka
2021-12-03 1:03 ` Stephen Boyd
2021-12-03 16:09 ` Bjorn Andersson
2021-12-06 22:41 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox