Re: [patch V2 21/31] soc: ti: ti_sci_inta_msi: Rework MSI descriptor allocation

Thomas Gleixner
2021-12-15T20:51:09Z

On Mon, Dec 06 2021 at 23:51, Thomas Gleixner wrote:
>
> No functional change intended.

Famous last words.

> static int ti_sci_inta_msi_alloc_descs(struct device *dev,
> struct ti_sci_resource *res)
> {
> - struct msi_desc *msi_desc;
> + struct msi_desc msi_desc;
> int set, i, count = 0;
>
> + memset(&msi_desc, 0, sizeof(msi_desc));

This fails to initialize msi_desc.nvec_used which makes the subsequent
interrupt allocation fail. Delta fix below.

Thanks,

tglx
---
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -68,6 +68,7 @@ static int ti_sci_inta_msi_alloc_descs(s
int set, i, count = 0;

memset(&msi_desc, 0, sizeof(msi_desc));
+ msi_desc.nvec_used = 1;

for (set = 0; set < res->sets; set++) {
for (i = 0; i < res->desc[set].num; i++, count++) {