* [PATCH][next] crypto: cavium - Use kcalloc() instead of kzalloc()
@ 2021-12-08 1:24 Gustavo A. R. Silva
2021-12-08 5:05 ` Kees Cook
2021-12-17 8:39 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-12-08 1:24 UTC (permalink / raw)
To: George Cherian, Herbert Xu, David S. Miller
Cc: linux-crypto, linux-kernel, Gustavo A. R. Silva, linux-hardening
Use 2-factor multiplication argument form kcalloc() instead
of kzalloc().
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/crypto/cavium/cpt/cptvf_main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/cavium/cpt/cptvf_main.c b/drivers/crypto/cavium/cpt/cptvf_main.c
index 112b12a32542..c246920e6f54 100644
--- a/drivers/crypto/cavium/cpt/cptvf_main.c
+++ b/drivers/crypto/cavium/cpt/cptvf_main.c
@@ -104,17 +104,14 @@ static int alloc_pending_queues(struct pending_qinfo *pqinfo, u32 qlen,
u32 nr_queues)
{
u32 i;
- size_t size;
int ret;
struct pending_queue *queue = NULL;
pqinfo->nr_queues = nr_queues;
pqinfo->qlen = qlen;
- size = (qlen * sizeof(struct pending_entry));
-
for_each_pending_queue(pqinfo, queue, i) {
- queue->head = kzalloc((size), GFP_KERNEL);
+ queue->head = kcalloc(qlen, sizeof(*queue->head), GFP_KERNEL);
if (!queue->head) {
ret = -ENOMEM;
goto pending_qfail;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] crypto: cavium - Use kcalloc() instead of kzalloc()
2021-12-08 1:24 [PATCH][next] crypto: cavium - Use kcalloc() instead of kzalloc() Gustavo A. R. Silva
@ 2021-12-08 5:05 ` Kees Cook
2021-12-17 8:39 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2021-12-08 5:05 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: George Cherian, Herbert Xu, David S. Miller, linux-crypto,
linux-kernel, linux-hardening
On Tue, Dec 07, 2021 at 07:24:59PM -0600, Gustavo A. R. Silva wrote:
> Use 2-factor multiplication argument form kcalloc() instead
> of kzalloc().
>
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] crypto: cavium - Use kcalloc() instead of kzalloc()
2021-12-08 1:24 [PATCH][next] crypto: cavium - Use kcalloc() instead of kzalloc() Gustavo A. R. Silva
2021-12-08 5:05 ` Kees Cook
@ 2021-12-17 8:39 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2021-12-17 8:39 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: George Cherian, David S. Miller, linux-crypto, linux-kernel,
linux-hardening
On Tue, Dec 07, 2021 at 07:24:59PM -0600, Gustavo A. R. Silva wrote:
> Use 2-factor multiplication argument form kcalloc() instead
> of kzalloc().
>
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/crypto/cavium/cpt/cptvf_main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-17 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-08 1:24 [PATCH][next] crypto: cavium - Use kcalloc() instead of kzalloc() Gustavo A. R. Silva
2021-12-08 5:05 ` Kees Cook
2021-12-17 8:39 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox