From: Neal Liu <neal_liu@aspeedtech.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Cai Huoqing <caihuoqing@baidu.com>,
Tao Ren <rentao.bupt@gmail.com>,
Julia Lawall <julia.lawall@inria.fr>,
"kernel test robot" <lkp@intel.com>,
Sasha Levin <sashal@kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <benh@kernel.crashing.org>
Cc: Neal Liu <neal_liu@aspeedtech.com>, <BMC-SW@aspeedtech.com>
Subject: [PATCH v3 3/4] usb: aspeed-vhub: fix ep0 OUT ack received wrong length issue
Date: Wed, 8 Dec 2021 18:05:44 +0800 [thread overview]
Message-ID: <20211208100545.1441397-4-neal_liu@aspeedtech.com> (raw)
In-Reply-To: <20211208100545.1441397-1-neal_liu@aspeedtech.com>
If multiple devices in vhub are enumerated simultaneously, ep0 OUT
ack might received wrong data length. Using expected data length
instead.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
---
drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
index 74ea36c19b1e..b4cf46249fea 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/ep0.c
@@ -251,6 +251,13 @@ static void ast_vhub_ep0_do_receive(struct ast_vhub_ep *ep, struct ast_vhub_req
len = remain;
rc = -EOVERFLOW;
}
+
+ /* Hardware return wrong data len */
+ if (len < ep->ep.maxpacket && len != remain) {
+ EPDBG(ep, "using expected data len instead\n");
+ len = remain;
+ }
+
if (len && req->req.buf)
memcpy(req->req.buf + req->req.actual, ep->buf, len);
req->req.actual += len;
--
2.25.1
next prev parent reply other threads:[~2021-12-08 10:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 10:05 [PATCH v3 0/4] Refactor Aspeed USB vhub driver Neal Liu
2021-12-08 10:05 ` [PATCH v3 1/4] usb: aspeed-vhub: add qualifier descriptor Neal Liu
2021-12-09 0:04 ` Benjamin Herrenschmidt
2021-12-08 10:05 ` [PATCH v3 2/4] usb: aspeed-vhub: fix remote wakeup failure in iKVM use case Neal Liu
2021-12-09 0:05 ` Benjamin Herrenschmidt
2021-12-09 2:37 ` Neal Liu
2021-12-14 2:35 ` Benjamin Herrenschmidt
2021-12-20 2:22 ` Neal Liu
2021-12-27 2:07 ` Neal Liu
2022-01-10 6:29 ` Neal Liu
2021-12-13 14:01 ` Greg Kroah-Hartman
2021-12-08 10:05 ` Neal Liu [this message]
2021-12-08 10:05 ` [PATCH v3 4/4] usb: aspeed-vhub: support test mode feature Neal Liu
2021-12-09 0:06 ` Benjamin Herrenschmidt
2021-12-08 12:21 ` [PATCH v3 0/4] Refactor Aspeed USB vhub driver Greg Kroah-Hartman
2021-12-09 2:39 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208100545.1441397-4-neal_liu@aspeedtech.com \
--to=neal_liu@aspeedtech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=balbi@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=caihuoqing@baidu.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=julia.lawall@inria.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rentao.bupt@gmail.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox