Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties

Thomas Gleixner
2021-12-07T12:47:42Z

On Tue, Dec 07 2021 at 10:04, Cédric Le Goater wrote:
>> +/**
>> + * msi_device_set_properties - Set device specific MSI properties
>> + * @dev: Pointer to the device which is queried
>> + * @prop: Properties to set
>> + */
>> +void msi_device_set_properties(struct device *dev, unsigned long prop)
>> +{
>> + if (WARN_ON_ONCE(!dev->msi.data))
>> + return ;
>> + dev->msi.data->properties = 0;
> It would work better if the prop variable was used instead of 0.
>
> With that fixed,

Indeed. Copy & pasta w/o brain usage ...