[patch V2 00/36] genirq/msi, PCI/MSI: Spring cleaning - Part 2

Thomas Gleixner
2021-12-06T22:39:01Z

This is the second part of [PCI]MSI refactoring which aims to provide the
ability of expanding MSI-X vectors after enabling MSI-X.

The first part of this work can be found here:

https://lore.kernel.org/r/20211206210147.872865823@linutronix.de

This second part has the following important changes:

1) Cleanup of the MSI related data in struct device

struct device contains at the moment various MSI related parts. Some
of them (the irq domain pointer) cannot be moved out, but the rest
can be allocated on first use. This is in preparation of adding more
per device MSI data later on.

2) Consolidation of sysfs handling

As a first step this moves the sysfs pointer from struct msi_desc
into the new per device MSI data structure where it belongs.

Later changes will cleanup this code further, but that's not possible
at this point.

3) Store per device properties in the per device MSI data to avoid
looking up MSI descriptors and analysing their data. Cleanup all
related use cases.

4) Provide a function to retrieve the Linux interrupt number for a given
MSI index similar to pci_irq_vector() and cleanup all open coded
variants.

This second series is based on:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v2-part-1

and also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v2-part-2

For the curious who can't wait for the next part to arrive the full series
is available via:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v2-part-3

V1 of this series can be found here:

https://lore.kernel.org/r/20211126224100.303046749@linutronix.de

Changes versus V1:

- Fix the pci_irq_vector() thinko - Marc

- Fix the powerpc fallout - Cedric, Andy

- Addressed codingstyle/comments feedback - Jonathan

- Added a MSI properties setter to prepare for later changes

- Confined the global msi*sysfs functions to legacy code

- Dropped the MSI lock patch as the lock has moved to struct pci_dev
in V2 part-1 now

- Picked up Reviewed/Tested/Acked-by tags as appropriate

Thanks,

tglx
---
arch/powerpc/platforms/cell/axon_msi.c | 6
arch/powerpc/platforms/pseries/msi.c | 39 +---
arch/x86/kernel/apic/msi.c | 5
arch/x86/pci/xen.c | 8
drivers/base/platform-msi.c | 152 +++++++---------
drivers/bus/fsl-mc/dprc-driver.c | 8
drivers/bus/fsl-mc/fsl-mc-allocator.c | 9
drivers/bus/fsl-mc/fsl-mc-msi.c | 26 +-
drivers/dma/mv_xor_v2.c | 16 -
drivers/dma/qcom/hidma.c | 44 ++--
drivers/dma/ti/k3-udma-private.c | 6
drivers/dma/ti/k3-udma.c | 14 -
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 23 --
drivers/irqchip/irq-mbigen.c | 4
drivers/irqchip/irq-mvebu-icu.c | 12 -
drivers/irqchip/irq-ti-sci-inta.c | 2
drivers/mailbox/bcm-flexrm-mailbox.c | 9
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4
drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 4
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 5
drivers/pci/msi/irqdomain.c | 20 +-
drivers/pci/msi/legacy.c | 6
drivers/pci/msi/msi.c | 118 ++++--------
drivers/pci/xen-pcifront.c | 2
drivers/perf/arm_smmuv3_pmu.c | 5
drivers/soc/fsl/dpio/dpio-driver.c | 8
drivers/soc/ti/k3-ringacc.c | 6
drivers/soc/ti/ti_sci_inta_msi.c | 22 --
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 4
include/linux/device.h | 25 ++
include/linux/fsl/mc.h | 4
include/linux/msi.h | 112 ++++++------
include/linux/pci.h | 1
include/linux/soc/ti/ti_sci_inta_msi.h | 1
kernel/irq/msi.c | 182 +++++++++++++++-----
35 files changed, 464 insertions(+), 448 deletions(-)