Re: [PATCH v3] net: dsa: mv88e6xxx: error handling for serdes_power functions

Ameer Hamza
2021-12-09T04:06:22Z

On Wed, Dec 08, 2021 at 05:28:20PM -0800, Jakub Kicinski wrote:
> On Wed, 8 Dec 2021 20:58:09 +0500 Ameer Hamza wrote:
> > @@ -1507,7 +1510,7 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
> > bool on)
> > {
> > u8 cmode = chip->ports[port].cmode;
> > - int err = 0;
> > + int err;
> >
> > if (port != 0 && port != 9 && port != 10)
> > return -EOPNOTSUPP;
>
> This is on top of v1? It doesn't seem to apply, v1 was not merged.
Oh, sorry! Its not incremental but I think my repository was a
few commits old. Let me send the updated patch.

> Also can you please add Fixes tags?
Sure.