From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-kernel@vger.kernel.org,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter
Date: Mon, 13 Dec 2021 08:57:25 +0100 [thread overview]
Message-ID: <20211213075725.GA20986@lst.de> (raw)
In-Reply-To: <20211213000636.2932569-2-willy@infradead.org>
On Mon, Dec 13, 2021 at 12:06:34AM +0000, Matthew Wilcox (Oracle) wrote:
> Instead of passing in a 'buf' and 'userbuf' argument, pass in an iov_iter.
> s390 needs more work to pass the iov_iter down further, or refactor,
> but I'd be more comfortable if someone who can test on s390 did that work.
>
> It's more convenient to convert the whole of read_from_oldmem() to
> take an iov_iter at the same time, so rename it to read_from_oldmem_iter()
> and add a temporary read_from_oldmem() wrapper that creates an iov_iter.
This looks pretty reasonable. s390 could use some love from people that
know the code, and yes, the kerneldoc comments should go away.
next prev parent reply other threads:[~2021-12-13 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 0:06 [PATCH 0/3] Convert vmcore to use an iov_iter Matthew Wilcox (Oracle)
2021-12-13 0:06 ` [PATCH 1/3] vmcore: Convert copy_oldmem_page() to take " Matthew Wilcox (Oracle)
2021-12-13 1:34 ` Matthew Wilcox
2021-12-13 2:33 ` kernel test robot
2021-12-13 7:57 ` Christoph Hellwig [this message]
2021-12-16 9:28 ` Heiko Carstens
2021-12-13 0:06 ` [PATCH 2/3] vmcore: Convert __read_vmcore to use " Matthew Wilcox (Oracle)
2021-12-13 3:24 ` kernel test robot
2021-12-13 8:00 ` Christoph Hellwig
2021-12-13 0:06 ` [PATCH 3/3] vmcore: Convert read_from_oldmem() to take " Matthew Wilcox (Oracle)
2021-12-13 4:04 ` kernel test robot
2021-12-13 8:02 ` Christoph Hellwig
2021-12-13 9:29 ` Baoquan He
2021-12-13 13:42 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213075725.GA20986@lst.de \
--to=hch@lst.de \
--cc=amit.kachhap@arm.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=willy@infradead.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox