Re: [PATCH nand-next] mtd/nand:remove unneeded variable

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello,

cgel.zte@gmail.com wrote on Fri, 10 Dec 2021 02:18:22 +0000:

> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return status directly from function called.

The subject prefix should be "mtd: rawnand: gpmi: "

> 
> Reported-by: Zeal Robot <zealci@zte.com.cm>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> index 10cc71829dcb..ab9d1099bafa 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> @@ -1425,7 +1425,6 @@ static int gpmi_ecc_write_page(struct nand_chip *chip, const uint8_t *buf,
>  	struct mtd_info *mtd = nand_to_mtd(chip);
>  	struct gpmi_nand_data *this = nand_get_controller_data(chip);
>  	struct bch_geometry *nfc_geo = &this->bch_geometry;
> -	int ret;
>  
>  	dev_dbg(this->dev, "ecc write page.\n");
>  
> @@ -1445,9 +1444,7 @@ static int gpmi_ecc_write_page(struct nand_chip *chip, const uint8_t *buf,
>  				    this->auxiliary_virt);
>  	}
>  
> -	ret = nand_prog_page_op(chip, page, 0, buf, nfc_geo->page_size);
> -
> -	return ret;
> +	return nand_prog_page_op(chip, page, 0, buf, nfc_geo->page_size);
>  }
>  
>  /*


Thanks,
Miquèl