From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B11C433EF for ; Mon, 13 Dec 2021 09:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233620AbhLMJQO convert rfc822-to-8bit (ORCPT ); Mon, 13 Dec 2021 04:16:14 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:60519 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231224AbhLMJQM (ORCPT ); Mon, 13 Dec 2021 04:16:12 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 3E44E200003; Mon, 13 Dec 2021 09:16:10 +0000 (UTC) Date: Mon, 13 Dec 2021 10:16:09 +0100 From: Miquel Raynal To: cgel.zte@gmail.com Cc: han.xu@nxp.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: Re: [PATCH nand-next] mtd/nand:remove unneeded variable Message-ID: <20211213101519.25f4e2e1@xps13> In-Reply-To: <20211210021822.423833-1-chi.minghao@zte.com.cn> References: <20211210021822.423833-1-chi.minghao@zte.com.cn> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, cgel.zte@gmail.com wrote on Fri, 10 Dec 2021 02:18:22 +0000: > From: Minghao Chi > > Return status directly from function called. The subject prefix should be "mtd: rawnand: gpmi: " > > Reported-by: Zeal Robot > Signed-off-by: Minghao Chi > --- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > index 10cc71829dcb..ab9d1099bafa 100644 > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > @@ -1425,7 +1425,6 @@ static int gpmi_ecc_write_page(struct nand_chip *chip, const uint8_t *buf, > struct mtd_info *mtd = nand_to_mtd(chip); > struct gpmi_nand_data *this = nand_get_controller_data(chip); > struct bch_geometry *nfc_geo = &this->bch_geometry; > - int ret; > > dev_dbg(this->dev, "ecc write page.\n"); > > @@ -1445,9 +1444,7 @@ static int gpmi_ecc_write_page(struct nand_chip *chip, const uint8_t *buf, > this->auxiliary_virt); > } > > - ret = nand_prog_page_op(chip, page, 0, buf, nfc_geo->page_size); > - > - return ret; > + return nand_prog_page_op(chip, page, 0, buf, nfc_geo->page_size); > } > > /* Thanks, Miquèl