Re: [PATCH v3 21/23] media: atmel: atmel-isc: add raw Bayer 8bit 10bit output formats

Jacopo Mondi
2022-01-12T09:04:44Z

Hi Eugen

On Mon, Dec 13, 2021 at 03:49:38PM +0200, Eugen Hristev wrote:
> The ISC can dump the 8 bit and 10 bit raw bayer formats directly to
> the memory.
> Thus, add them to the supported output format list.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Thanks
j

> ---
> .../media/platform/atmel/atmel-sama5d2-isc.c | 24 +++++++++++++++++++
> .../media/platform/atmel/atmel-sama7g5-isc.c | 24 +++++++++++++++++++
> 2 files changed, 48 insertions(+)
>
> diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> index a8d4ba60d3ac..025c3e8a7e95 100644
> --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> @@ -88,6 +88,30 @@ static const struct isc_format sama5d2_controller_formats[] = {
> {
> .fourcc = V4L2_PIX_FMT_Y10,
> },
> + {
> + .fourcc = V4L2_PIX_FMT_SBGGR8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGBRG8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGRBG8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SRGGB8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SBGGR10,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGBRG10,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGRBG10,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SRGGB10,
> + },
> };
>
> /* This is a list of formats that the ISC can receive as *input* */
> diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> index 38721bd902e2..9dc75eed0098 100644
> --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c
> @@ -100,6 +100,30 @@ static const struct isc_format sama7g5_controller_formats[] = {
> {
> .fourcc = V4L2_PIX_FMT_Y16,
> },
> + {
> + .fourcc = V4L2_PIX_FMT_SBGGR8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGBRG8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGRBG8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SRGGB8,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SBGGR10,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGBRG10,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SGRBG10,
> + },
> + {
> + .fourcc = V4L2_PIX_FMT_SRGGB10,
> + },
> };
>
> /* This is a list of formats that the ISC can receive as *input* */
> --
> 2.25.1
>