Re: [PATCH v3 00/23] media: atmel: atmel-isc: implement media controller

Hans Verkuil
2022-01-12T12:07:28Z

Hi Eugen,

On 13/12/2021 14:49, Eugen Hristev wrote:
> This series is the v3 of the series that attempts to support media controller
> in the atmel ISC and XISC drivers.
> This series also includes the csi2dc driver which was previously sent in a
> separate series:
> https://www.spinics.net/lists/linux-media/msg181042.html
> https://www.spinics.net/lists/linux-media/msg181044.html
> The driver now addresses comments received in latest v5 series from last year.
>
> The series includes some minor changes and fixes that improve the isc common
> code base, like removing the enum frameintervals VIDIOC, fixing bytesperline
> for planar formats, etc.
>
> Many thanks to folks from libcamera who helped a lot with understanding
> how a media controller driver should behave.
>
> Feedback is welcome !
>
> Changes in v3:
> - change in bindings, small fixes in csi2dc driver and conversion to mc
> for the isc-base.
> - removed some MAINTAINERS patches and used patterns in MAINTAINERS
>
> Changes in v2:
> - integrated many changes suggested by Jacopo in the review of the v1 series.
> - add a few new patches

Based on the current review status I think it would make sense to add
the following patches from this series to a PR:

1-6, 8-9, 11, 16, 18-22.

Are there any patches (esp. 11 and later) that require other patches
not in this list? In other words, does this make sense?

Regards,

Hans

>
>
> Eugen Hristev (23):
> MAINTAINERS: add microchip csi2dc
> dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc
> media: atmel: introduce microchip csi2dc driver
> media: atmel: atmel-isc: split the clock code into separate source
> file
> media: atmel: atmel-isc: replace video device name with module name
> media: atmel: atmel-sama7g5-isc: fix ispck leftover
> media: atmel: atmel-isc-base: use streaming status when queueing
> buffers
> media: atmel: atmel-isc-base: remove frameintervals VIDIOC
> media: atmel: atmel-isc-base: report frame sizes as full supported
> range
> media: atmel: atmel-isc-base: implement mbus_code support in enumfmt
> media: atmel: atmel-isc-base: fix bytesperline value for planar
> formats
> media: atmel: atmel-isc: implement media controller
> ARM: dts: at91: sama7g5: add nodes for video capture
> ARM: configs: at91: sama7: add xisc and csi2dc
> ARM: multi_v7_defconfig: add atmel video pipeline modules
> media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check
> media: atmel: atmel-isc-base: use mutex to lock awb workqueue from
> streaming
> media: atmel: atmel-isc-base: add wb debug messages
> media: atmel: atmel-isc-base: clamp wb gain coefficients
> media: atmel: atmel-sama7g5-isc: fix UYVY input format mbus_code typo
> media: atmel: atmel-isc: add raw Bayer 8bit 10bit output formats
> media: atmel: atmel-isc: compact the controller formats list
> media: atmel: atmel-isc: change format propagation to subdev into only
> verification
>
> .../bindings/media/microchip,csi2dc.yaml | 197 +++++
> MAINTAINERS | 14 +-
> arch/arm/boot/dts/sama7g5.dtsi | 48 ++
> arch/arm/configs/multi_v7_defconfig | 3 +
> arch/arm/configs/sama7_defconfig | 2 +
> drivers/media/platform/Makefile | 1 +
> drivers/media/platform/atmel/Kconfig | 15 +
> drivers/media/platform/atmel/Makefile | 4 +-
> drivers/media/platform/atmel/atmel-isc-base.c | 790 ++++++-----------
> drivers/media/platform/atmel/atmel-isc-clk.c | 311 +++++++
> drivers/media/platform/atmel/atmel-isc-mc.c | 287 +++++++
> drivers/media/platform/atmel/atmel-isc.h | 49 ++
> .../media/platform/atmel/atmel-sama5d2-isc.c | 59 +-
> .../media/platform/atmel/atmel-sama7g5-isc.c | 72 +-
> .../media/platform/atmel/microchip-csi2dc.c | 806 ++++++++++++++++++
> 15 files changed, 2085 insertions(+), 573 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/microchip,csi2dc.yaml
> create mode 100644 drivers/media/platform/atmel/atmel-isc-clk.c
> create mode 100644 drivers/media/platform/atmel/atmel-isc-mc.c
> create mode 100644 drivers/media/platform/atmel/microchip-csi2dc.c
>