Re: [PATCH] PM / devfreq: sun8i: addd COMMON_CLK dependency

Chanwoo Choi
2021-12-16T02:07:12Z

On 12/15/21 11:03 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing the driver without CONFIG_COMMON_CLK causes
> a link failure:
>
> arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_remove':
> sun8i-a33-mbus.c:(.text+0x450): undefined reference to `clk_rate_exclusive_put'
> arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x460): undefined reference to `clk_rate_exclusive_put'
> arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_probe':
> sun8i-a33-mbus.c:(.text+0x85c): undefined reference to `clk_rate_exclusive_get'
> arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x878): undefined reference to `clk_rate_exclusive_get'
>
> Fixes: 8bfd4858b4bb ("PM / devfreq: Add a driver for the sun8i/sun50i MBUS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/devfreq/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index b94eb04761f6..87eb2b837e68 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -135,6 +135,7 @@ config ARM_RK3399_DMC_DEVFREQ
> config ARM_SUN8I_A33_MBUS_DEVFREQ
> tristate "sun8i/sun50i MBUS DEVFREQ Driver"
> depends on ARCH_SUNXI || COMPILE_TEST
> + depends on COMMON_CLK
> select DEVFREQ_GOV_SIMPLE_ONDEMAND
> help
> This adds the DEVFREQ driver for the MBUS controller in some
>

Thanks. Applied it.

--
Best Regards,
Chanwoo Choi
Samsung Electronics