From: Quentin Perret <qperret@google.com>
To: Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: qperret@google.com, qwandor@google.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
kernel-team@android.com
Subject: [PATCH v4 00/14] KVM: arm64: Introduce kvm_{un}share_hyp()
Date: Wed, 15 Dec 2021 16:12:17 +0000 [thread overview]
Message-ID: <20211215161232.1480836-1-qperret@google.com> (raw)
Hi all,
This is v4 of the series previously posted here:
https://lore.kernel.org/kvmarm/20211201170411.1561936-1-qperret@google.com/
This series implements an unshare hypercall at EL2 in nVHE protected
mode, and makes use of it to unmmap guest-specific data-structures from
EL2 stage-1 during guest tear-down. Crucially, the implementation of the
share and unshare routines use page refcounts in the host kernel to
avoid accidentally unmapping data-structures that overlap a common page.
This series has two main benefits. Firstly it allows EL2 to track the
state of shared pages cleanly, as they can now transition from SHARED
back to OWNED. This will simplify permission checks once e.g. pkvm
implements a donation hcall to provide memory to protected guests, as
there should then be no reason for the host to donate a page that is
currently marked shared. And secondly, it avoids having dangling
mappings in the hypervisor's stage-1, which should be a good idea from
a security perspective as the hypervisor is obviously running with
elevated privileges. And perhaps worth noting is that this also
refactors the EL2 page-tracking checks in a more scalable way, which
should allow to implement other memory transitions (host donating memory
to a guest, a guest sharing back with the host, ...) much more easily in
the future.
Changes since v3:
- fixed refcount of hyp stage-1 page-table pages when only changing SW
bits (Will)
- misc minor cleanups (Will, Andrew)
- rebased on kvmarm/next
Quentin Perret (6):
KVM: arm64: Provide {get,put}_page() stubs for early hyp allocator
KVM: arm64: Refcount hyp stage-1 pgtable pages
KVM: arm64: Fixup hyp stage-1 refcount
KVM: arm64: Introduce kvm_share_hyp()
KVM: arm64: pkvm: Refcount the pages shared with EL2
KVM: arm64: pkvm: Unshare guest structs during teardown
Will Deacon (8):
KVM: arm64: Hook up ->page_count() for hypervisor stage-1 page-table
KVM: arm64: Implement kvm_pgtable_hyp_unmap() at EL2
KVM: arm64: Extend pkvm_page_state enumeration to handle absent pages
KVM: arm64: Introduce wrappers for host and hyp spin lock accessors
KVM: arm64: Implement do_share() helper for sharing memory
KVM: arm64: Implement __pkvm_host_share_hyp() using do_share()
KVM: arm64: Implement do_unshare() helper for unsharing memory
KVM: arm64: Expose unshare hypercall to the host
arch/arm64/include/asm/kvm_asm.h | 1 +
arch/arm64/include/asm/kvm_host.h | 2 +
arch/arm64/include/asm/kvm_mmu.h | 2 +
arch/arm64/include/asm/kvm_pgtable.h | 21 +
arch/arm64/kvm/arm.c | 6 +-
arch/arm64/kvm/fpsimd.c | 36 +-
arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 6 +
arch/arm64/kvm/hyp/nvhe/early_alloc.c | 5 +
arch/arm64/kvm/hyp/nvhe/hyp-main.c | 8 +
arch/arm64/kvm/hyp/nvhe/mem_protect.c | 500 +++++++++++++++---
arch/arm64/kvm/hyp/nvhe/setup.c | 22 +-
arch/arm64/kvm/hyp/pgtable.c | 102 +++-
arch/arm64/kvm/mmu.c | 137 ++++-
arch/arm64/kvm/reset.c | 10 +-
14 files changed, 739 insertions(+), 119 deletions(-)
--
2.34.1.173.g76aa8bc2d0-goog
next reply other threads:[~2021-12-15 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:12 Quentin Perret [this message]
2021-12-15 16:12 ` [PATCH v4 01/14] KVM: arm64: Provide {get,put}_page() stubs for early hyp allocator Quentin Perret
2021-12-15 16:12 ` [PATCH v4 02/14] KVM: arm64: Refcount hyp stage-1 pgtable pages Quentin Perret
2021-12-15 16:12 ` [PATCH v4 03/14] KVM: arm64: Fixup hyp stage-1 refcount Quentin Perret
2021-12-15 16:12 ` [PATCH v4 04/14] KVM: arm64: Hook up ->page_count() for hypervisor stage-1 page-table Quentin Perret
2021-12-15 16:12 ` [PATCH v4 05/14] KVM: arm64: Implement kvm_pgtable_hyp_unmap() at EL2 Quentin Perret
2021-12-15 16:12 ` [PATCH v4 06/14] KVM: arm64: Introduce kvm_share_hyp() Quentin Perret
2021-12-15 16:12 ` [PATCH v4 07/14] KVM: arm64: pkvm: Refcount the pages shared with EL2 Quentin Perret
2021-12-15 16:12 ` [PATCH v4 08/14] KVM: arm64: Extend pkvm_page_state enumeration to handle absent pages Quentin Perret
2021-12-15 16:12 ` [PATCH v4 09/14] KVM: arm64: Introduce wrappers for host and hyp spin lock accessors Quentin Perret
2021-12-15 16:12 ` [PATCH v4 10/14] KVM: arm64: Implement do_share() helper for sharing memory Quentin Perret
2021-12-15 16:12 ` [PATCH v4 11/14] KVM: arm64: Implement __pkvm_host_share_hyp() using do_share() Quentin Perret
2021-12-15 16:12 ` [PATCH v4 12/14] KVM: arm64: Implement do_unshare() helper for unsharing memory Quentin Perret
2021-12-15 16:12 ` [PATCH v4 13/14] KVM: arm64: Expose unshare hypercall to the host Quentin Perret
2021-12-15 16:12 ` [PATCH v4 14/14] KVM: arm64: pkvm: Unshare guest structs during teardown Quentin Perret
2021-12-16 13:07 ` [PATCH v4 00/14] KVM: arm64: Introduce kvm_{un}share_hyp() Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215161232.1480836-1-qperret@google.com \
--to=qperret@google.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=qwandor@google.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox