From: Guenter Roeck <linux@roeck-us.net>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: prefix kernel-doc comments for structs with struct
Date: Fri, 17 Dec 2021 07:45:12 -0800 [thread overview]
Message-ID: <20211217154512.GA2882803@roeck-us.net> (raw)
In-Reply-To: <20211216154257.26758-1-lukas.bulwahn@gmail.com>
On Thu, Dec 16, 2021 at 04:42:57PM +0100, Lukas Bulwahn wrote:
> The command ./scripts/kernel-doc -none include/linux/hwmon.h warns:
>
> include/linux/hwmon.h:406: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Channel information
> include/linux/hwmon.h:425: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Chip configuration
>
> Address those kernel-doc warnings by prefixing kernel-doc descriptions for
> structs with the keyword 'struct'.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Applied.
Thanks,
Guenter
> ---
> include/linux/hwmon.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> index 1e8d6ea8992e..fad1f1df26df 100644
> --- a/include/linux/hwmon.h
> +++ b/include/linux/hwmon.h
> @@ -403,7 +403,7 @@ struct hwmon_ops {
> };
>
> /**
> - * Channel information
> + * struct hwmon_channel_info - Channel information
> * @type: Channel type.
> * @config: Pointer to NULL-terminated list of channel parameters.
> * Use for per-channel attributes.
> @@ -422,7 +422,7 @@ struct hwmon_channel_info {
> })
>
> /**
> - * Chip configuration
> + * struct hwmon_chip_info - Chip configuration
> * @ops: Pointer to hwmon operations.
> * @info: Null-terminated list of channel information.
> */
prev parent reply other threads:[~2021-12-17 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 15:42 [PATCH] hwmon: prefix kernel-doc comments for structs with struct Lukas Bulwahn
2021-12-17 15:45 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217154512.GA2882803@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox