From: kernel test robot <lkp@intel.com>
To: Wenjing Liu <wenjing.liu@amd.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>,
Jun Lei <Jun.Lei@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1700 dp_perform_8b_10b_link_training() warn: inconsistent indenting
Date: Sun, 19 Dec 2021 18:49:16 +0800 [thread overview]
Message-ID: <202112191837.wHojpl3e-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3f667b5d4053ad54aee13dab5c94f04ff75ddfdf
commit: cd6a9a1c15c2942c6a3b19a33a2523a18229ec4a drm/amd/display: isolate 8b 10b link training sequence into its own function
date: 7 months ago
config: x86_64-randconfig-m001-20211207 (https://download.01.org/0day-ci/archive/20211219/202112191837.wHojpl3e-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1700 dp_perform_8b_10b_link_training() warn: inconsistent indenting
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1857 perform_link_training_with_retries() warn: inconsistent indenting
vim +1700 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c
3df212576e8b6f Wenjing Liu 2021-05-03 1657
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1658 static enum link_training_result dp_perform_8b_10b_link_training(
e0a6440a2961b1 David Galiffi 2019-05-30 1659 struct dc_link *link,
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1660 struct link_training_settings *lt_settings)
e0a6440a2961b1 David Galiffi 2019-05-30 1661 {
e0a6440a2961b1 David Galiffi 2019-05-30 1662 enum link_training_result status = LINK_TRAINING_SUCCESS;
64c12b733fe7ea abdoulaye berthe 2019-07-24 1663
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1664 uint8_t repeater_cnt;
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1665 uint8_t repeater_id;
bcc5042a220903 abdoulaye berthe 2020-02-18 1666
82054678aeb669 Martin Leung 2020-02-12 1667 if (link->ctx->dc->work_arounds.lt_early_cr_pattern)
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1668 start_clock_recovery_pattern_early(link, lt_settings, DPRX);
834a9a9f04c708 Martin Leung 2020-02-13 1669
834a9a9f04c708 Martin Leung 2020-02-13 1670 /* 1. set link rate, lane count and spread. */
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1671 dpcd_set_link_settings(link, lt_settings);
e0a6440a2961b1 David Galiffi 2019-05-30 1672
3128b285021ec0 Wesley Chalmers 2021-03-15 1673 if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT) {
008a4016c5cf92 Nikola Cornij 2019-06-24 1674
e0a6440a2961b1 David Galiffi 2019-05-30 1675 /* 2. perform link training (set link training done
e0a6440a2961b1 David Galiffi 2019-05-30 1676 * to false is done as well)
e0a6440a2961b1 David Galiffi 2019-05-30 1677 */
573a0a03af0253 Jimmy Kizito 2021-04-09 1678 repeater_cnt = dp_convert_to_count(link->dpcd_caps.lttpr_caps.phy_repeater_cnt);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1679
64c12b733fe7ea abdoulaye berthe 2019-07-24 1680 for (repeater_id = repeater_cnt; (repeater_id > 0 && status == LINK_TRAINING_SUCCESS);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1681 repeater_id--) {
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1682 status = perform_clock_recovery_sequence(link, lt_settings, repeater_id);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1683
64c12b733fe7ea abdoulaye berthe 2019-07-24 1684 if (status != LINK_TRAINING_SUCCESS)
64c12b733fe7ea abdoulaye berthe 2019-07-24 1685 break;
64c12b733fe7ea abdoulaye berthe 2019-07-24 1686
64c12b733fe7ea abdoulaye berthe 2019-07-24 1687 status = perform_channel_equalization_sequence(link,
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1688 lt_settings,
64c12b733fe7ea abdoulaye berthe 2019-07-24 1689 repeater_id);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1690
64c12b733fe7ea abdoulaye berthe 2019-07-24 1691 if (status != LINK_TRAINING_SUCCESS)
64c12b733fe7ea abdoulaye berthe 2019-07-24 1692 break;
64c12b733fe7ea abdoulaye berthe 2019-07-24 1693
64c12b733fe7ea abdoulaye berthe 2019-07-24 1694 repeater_training_done(link, repeater_id);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1695 }
64c12b733fe7ea abdoulaye berthe 2019-07-24 1696 }
64c12b733fe7ea abdoulaye berthe 2019-07-24 1697
64c12b733fe7ea abdoulaye berthe 2019-07-24 1698 if (status == LINK_TRAINING_SUCCESS) {
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1699 status = perform_clock_recovery_sequence(link, lt_settings, DPRX);
e0a6440a2961b1 David Galiffi 2019-05-30 @1700 if (status == LINK_TRAINING_SUCCESS) {
e0a6440a2961b1 David Galiffi 2019-05-30 1701 status = perform_channel_equalization_sequence(link,
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1702 lt_settings,
64c12b733fe7ea abdoulaye berthe 2019-07-24 1703 DPRX);
64c12b733fe7ea abdoulaye berthe 2019-07-24 1704 }
e0a6440a2961b1 David Galiffi 2019-05-30 1705 }
e0a6440a2961b1 David Galiffi 2019-05-30 1706
cd6a9a1c15c294 Wenjing Liu 2021-05-04 1707 return status;
e0a6440a2961b1 David Galiffi 2019-05-30 1708 }
e0a6440a2961b1 David Galiffi 2019-05-30 1709
:::::: The code at line 1700 was first introduced by commit
:::::: e0a6440a2961b1da3ea895b0bef082fc1a78e190 drm/amd/display: Add ability to set preferred link training parameters.
:::::: TO: David Galiffi <David.Galiffi@amd.com>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
reply other threads:[~2021-12-19 10:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112191837.wHojpl3e-lkp@intel.com \
--to=lkp@intel.com \
--cc=Jun.Lei@amd.com \
--cc=alexander.deucher@amd.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox