From: Lukas Wunner <lukas@wunner.de>
To: "Pali Rohár" <pali@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Wilczy??ski <kw@linux.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Add defines for normal and subtractive PCI bridges
Date: Mon, 20 Dec 2021 17:21:50 +0100 [thread overview]
Message-ID: <20211220162150.GA706@wunner.de> (raw)
In-Reply-To: <20211220145140.31898-1-pali@kernel.org>
On Mon, Dec 20, 2021 at 03:51:40PM +0100, Pali Rohár wrote:
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -178,9 +178,9 @@ static pci_ers_result_t pcie_portdrv_mmio_enabled(struct pci_dev *dev)
> */
> static const struct pci_device_id port_pci_ids[] = {
> /* handle any PCI-Express port */
> - { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0) },
> + { PCI_DEVICE_CLASS(PCI_CLASS_BRIDGE_PCI_NORMAL, ~0) },
> /* subtractive decode PCI-to-PCI bridge, class type is 060401h */
> - { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0) },
> + { PCI_DEVICE_CLASS(PCI_CLASS_BRIDGE_PCI_SUBTRACTIVE, ~0) },
Any harm in simply matching for 0x060400 with mask 0xffff00?
next prev parent reply other threads:[~2021-12-20 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 14:53 [PATCH] PCI: Add defines for normal and subtractive PCI bridges Pali Rohár
2021-12-20 14:51 ` [PATCH v2] " Pali Rohár
2021-12-20 16:21 ` Lukas Wunner [this message]
2021-12-20 17:51 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220162150.GA706@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox