Re: [PATCH v3 0/3] Convert vmcore to use an iov_iter

Baoquan He
2021-12-16T08:43:42Z

On 12/13/21 at 02:39pm, Matthew Wilcox (Oracle) wrote:
> For some reason several people have been sending bad patches to fix
> compiler warnings in vmcore recently. Here's how it should be done.
> Compile-tested only on x86. As noted in the first patch, s390 should
> take this conversion a bit further, but I'm not inclined to do that
> work myself.

Add Philipp to the CC.

He used to work on s390 arch. Now he joins Redhat and will focus
on kexec/kdump. See if he has any thoughts on the s390 part of work, or
may reach out to s390 developer.

>
> v3:
> - Send the correct patches this time
> v2:
> - Removed unnecessary kernel-doc
> - Included uio.h to fix compilation problems
> - Made read_from_oldmem_iter static to avoid compile warnings during the
> conversion
> - Use iov_iter_truncate() (Christoph)
>
> Matthew Wilcox (Oracle) (3):
> vmcore: Convert copy_oldmem_page() to take an iov_iter
> vmcore: Convert __read_vmcore to use an iov_iter
> vmcore: Convert read_from_oldmem() to take an iov_iter
>
> arch/arm/kernel/crash_dump.c | 27 +------
> arch/arm64/kernel/crash_dump.c | 29 +------
> arch/ia64/kernel/crash_dump.c | 32 +-------
> arch/mips/kernel/crash_dump.c | 27 +------
> arch/powerpc/kernel/crash_dump.c | 35 ++-------
> arch/riscv/kernel/crash_dump.c | 26 +------
> arch/s390/kernel/crash_dump.c | 13 ++--
> arch/sh/kernel/crash_dump.c | 29 ++-----
> arch/x86/kernel/crash_dump_32.c | 29 +------
> arch/x86/kernel/crash_dump_64.c | 48 ++++--------
> fs/proc/vmcore.c | 129 +++++++++++++------------------
> include/linux/crash_dump.h | 19 ++---
> 12 files changed, 122 insertions(+), 321 deletions(-)
>
> --
> 2.33.0
>