From: Christoph Hellwig <hch@lst.de>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, target-devel@vger.kernel.org,
linux-scsi@vger.kernel.org, hch@lst.de, james.smart@broadcom.com,
martin.petersen@oracle.com
Subject: Re: [PATCH -next] scsi: efct: Use GFP_ATOMIC under spin lock
Date: Tue, 21 Dec 2021 15:28:59 +0100 [thread overview]
Message-ID: <20211221142859.GA30187@lst.de> (raw)
In-Reply-To: <20211221113706.329791-1-yangyingliang@huawei.com>
On Tue, Dec 21, 2021 at 07:37:06PM +0800, Yang Yingliang wrote:
> A spin lock is taken here so we should use GFP_ATOMIC.
>
> Fixes: efac162a4e4d ("scsi: efct: Don't pass GFP_DMA to dma_alloc_coherent()")
No, it does not fix that commit. The driver did sleeping allocations
even before the commit.
But wher is "here"? Can we look into not holding that lock over an
allocation if it is preferable? If not we should at least pass down
the gfp_flags so that only the caller(s) that can't sleep pass GFP_ATOMIC.
next prev parent reply other threads:[~2021-12-21 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 11:37 [PATCH -next] scsi: efct: Use GFP_ATOMIC under spin lock Yang Yingliang
2021-12-21 14:28 ` Christoph Hellwig [this message]
2021-12-23 3:56 ` Yang Yingliang
2022-01-10 8:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221142859.GA30187@lst.de \
--to=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox