Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing function

Liam Beguin
2021-12-22T19:42:16Z

On Wed, Dec 22, 2021 at 08:52:30PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 8:20 PM Liam Beguin <liambeguin@gmail.com> wrote:
> > On Wed, Dec 22, 2021 at 12:21:01PM +0200, Andy Shevchenko wrote:
> > > On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin <liambeguin@gmail.com> wrote:
>
> ...
>
> > > > #include <linux/iio/consumer.h>
> > > > #include <linux/iio/iio.h>
> > > > +#include <linux/iio/afe/rescale.h>
> > >
> > > It should go before the consumer.h, no?
> >
> > I don't mind making the change, but why should it go before consumer.h?
>
> 'a' is earlier than 'c' in the alphabet, no?
>
> ...
>
> > > And I would rather move the entire IIO group of headers...
> >
> > I can do that too. Do we have a convention for the ordering of #includes?
> > What's usually the rule/guideline for this?
>
> Guidelines suggest sorting without clear instructions. But in IIO and
> pin control I suggest people use this kind of grouping.

Understood, will update.

> > > > #include <linux/module.h>
> > > > #include <linux/of.h>
> > > > #include <linux/of_device.h>
> > > > #include <linux/platform_device.h>
> > > > #include <linux/property.h>
> > >
> > > ... somewhere here (with blank line above).
> > >
> > > > -struct rescale;
>
> ...
>
> > > Missed types.h and forward declarations like
> > > struct device;
> >
> > Okay. will add linux/types.h
>
> What about forward declaration?

I'm not sure I understand what you mean here.

Cheers,
Liam

> --
> With Best Regards,
> Andy Shevchenko