From: Tomohito Esaki <etom@igel.co.jp>
To: dri-devel@lists.freedesktop.org
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Michel Dänzer" <mdaenzer@redhat.com>,
"Simon Ser" <contact@emersion.fr>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
"Mark Yacoub" <markyacoub@chromium.org>,
"Sean Paul" <seanpaul@chromium.org>,
"Evan Quan" <evan.quan@amd.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Petr Mladek" <pmladek@suse.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Abhinav Kumar" <abhinavk@codeaurora.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Rob Clark" <robdclark@chromium.org>,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nouveau@lists.freedesktop.org, "Tomohito Esaki" <etom@igel.co.jp>,
"Damian Hobson-Garcia" <dhobsong@igel.co.jp>,
"Takanari Hayama" <taki@igel.co.jp>
Subject: [RFC PATCH 0/3] Add support modifiers for drivers whose planes only support linear layout
Date: Wed, 22 Dec 2021 14:27:24 +0900 [thread overview]
Message-ID: <20211222052727.19725-1-etom@igel.co.jp> (raw)
Some drivers whose planes only support linear layout fb do not support format
modifiers.
These drivers should support modifiers, however the DRM core should handle this
rather than open-coding in every driver.
In this patch series, these drivers expose format modifiers based on the
following suggestion[1].
On Thu, Nov 18, 2021 at 01:02:11PM +0000, Daniel Stone wrote:
> I think the best way forward here is:
> - add a new mode_config.cannot_support_modifiers flag, and enable
> this in radeon (plus any other drivers in the same boat)
> - change drm_universal_plane_init() to advertise the LINEAR modifier
> when NULL is passed as the modifier list (including installing a
> default .format_mod_supported hook)
> - remove the mode_config.allow_fb_modifiers hook and always
> advertise modifier support, unless
> mode_config.cannot_support_modifiers is set
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20190509054518.10781-1-etom@igel.co.jp/#24602575
Tomohito Esaki (3):
drm: add support modifiers for drivers whose planes only support
linear layout
drm: set fb_modifiers_not_supported flag in legacy drivers
drm: replace allow_fb_modifiers with fb_modifiers_not_supported
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +--
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 +
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +
drivers/gpu/drm/drm_framebuffer.c | 6 +--
drivers/gpu/drm/drm_ioctl.c | 2 +-
drivers/gpu/drm/drm_plane.c | 41 +++++++++++--------
drivers/gpu/drm/nouveau/nouveau_display.c | 6 ++-
drivers/gpu/drm/radeon/radeon_display.c | 2 +
.../gpu/drm/selftests/test-drm_framebuffer.c | 1 -
include/drm/drm_mode_config.h | 18 +++-----
include/drm/drm_plane.h | 3 ++
13 files changed, 54 insertions(+), 38 deletions(-)
--
2.17.1
next reply other threads:[~2021-12-22 5:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 5:27 Tomohito Esaki [this message]
2021-12-22 5:27 ` [RFC PATH 1/3] drm: add support modifiers for drivers whose planes only support linear layout Tomohito Esaki
2022-01-14 16:50 ` Daniel Vetter
2022-01-17 2:45 ` Esaki Tomohito
2021-12-22 5:27 ` [RFC PATH 2/3] drm: set fb_modifiers_not_supported flag in legacy drivers Tomohito Esaki
2021-12-22 5:27 ` [RFC PATH 3/3] drm: replace allow_fb_modifiers with fb_modifiers_not_supported Tomohito Esaki
2022-01-05 23:57 ` [RFC PATCH 0/3] Add support modifiers for drivers whose planes only support linear layout Simon Ser
2022-01-12 2:13 ` Esaki Tomohito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222052727.19725-1-etom@igel.co.jp \
--to=etom@igel.co.jp \
--cc=Xinhui.Pan@amd.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bas@basnieuwenhuizen.nl \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dhobsong@igel.co.jp \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyacoub@chromium.org \
--cc=mdaenzer@redhat.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=pmladek@suse.com \
--cc=qingqing.zhuo@amd.com \
--cc=robdclark@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=seanpaul@chromium.org \
--cc=taki@igel.co.jp \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox