RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver

Chen, Mike Ximing
2021-12-21T23:22:26Z

> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Tuesday, December 21, 2021 2:00 AM
> To: Chen, Mike Ximing <mike.ximing.chen@intel.com>; linux-kernel@vger.kernel.org
> Cc: arnd@arndb.de; gregkh@linuxfoundation.org; Williams, Dan J <dan.j.williams@intel.com>; pierre-
> louis.bossart@linux.intel.com; netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org
> Subject: Re: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
>
> On Tue, 2021-12-21 at 00:50 -0600, Mike Ximing Chen wrote:
> > Add a DLB entry to the MAINTAINERS file.
>
> btw: Nice documentation
>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -9335,6 +9335,13 @@ L: linux-kernel@vger.kernel.org
> > S: Supported
> > F: arch/x86/include/asm/intel-family.h
> >
> > +INTEL DYNAMIC LOAD BALANCER DRIVER
> > +M: Mike Ximing Chen <mike.ximing.chen@intel.com>
> > +S: Maintained
> > +F: Documentation/ABI/testing/sysfs-driver-dlb
> > +F: drivers/misc/dlb/
> > +F: include/uapi/linux/dlb.h
> > +
> > INTEL DRM DRIVERS (excluding Poulsbo, Moorestown and derivative chipsets)
> > M: Jani Nikula <jani.nikula@linux.intel.com>
> > M: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Section is not in the appropriate alphabetic order.
>
> dynamic should be after drm
>
Thanks. Will fix.

> > diff --git a/drivers/misc/dlb/dlb_main.c b/drivers/misc/dlb/dlb_main.c
> []
> > +// SPDX-License-Identifier: GPL-2.0-only
> []
> > +MODULE_LICENSE("GPL v2");
>
> Should use "GPL" not "GPL v2".
>
> https://lore.kernel.org/lkml/alpine.DEB.2.21.1901282105450.1669@nanos.tec.linutronix.de/
>
We support v2 only.

* "GPL" [GNU Public License v2 or later]
* "GPL v2" [GNU Public License v2]