From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: David Heidelberg <david@ixit.cz>
Cc: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
agross@kernel.org, bjorn.andersson@linaro.org
Subject: Re: Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node
Date: Wed, 22 Dec 2021 14:49:10 +0530 [thread overview]
Message-ID: <20211222091910.GA5159@thinkpad> (raw)
In-Reply-To: <20211221071219.GD26872@thinkpad>
On Tue, Dec 21, 2021 at 12:42:25PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Dec 20, 2021 at 09:27:17PM +0100, David Heidelberg wrote:
> > Hello Manivannan,
> >
> > I'd like to ask, if you had any particular reason to name node `qcom,spmi@`
> > instead of basic `spmi@`.
> >
>
> "spmi" node label was not documented by devicetree spec at that time. So I was
> using "qcom,spmi" but it was not correct either.
>
> I've submitted a PR now to devicetree-spec repo [1] for listing it as the
> generic node name. So once it got accepted, we can use "spmi@" for the node
> name.
>
PR is merged now. So you can proceed with using "spmi" node name in all dts.
Thanks,
Mani
> Thanks,
> Mani
>
> [1] https://github.com/devicetree-org/devicetree-specification/pull/50
>
> > I'm currently converting binding for
> > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
> > considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename this and
> > arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences to `spmi@`.
> >
> > Ideas, inputs?
> >
> > Thank you
> > David
> >
> >
next prev parent reply other threads:[~2021-12-22 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 20:27 Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node David Heidelberg
2021-12-21 7:12 ` Manivannan Sadhasivam
2021-12-22 9:19 ` Manivannan Sadhasivam [this message]
2021-12-22 12:23 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222091910.GA5159@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox