* Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node
@ 2021-12-20 20:27 David Heidelberg
2021-12-21 7:12 ` Manivannan Sadhasivam
0 siblings, 1 reply; 4+ messages in thread
From: David Heidelberg @ 2021-12-20 20:27 UTC (permalink / raw)
To: Manivannan Sadhasivam, Rob Herring
Cc: Vinod Koul, linux-arm-msm, linux-kernel, agross, bjorn.andersson
Hello Manivannan,
I'd like to ask, if you had any particular reason to name node
`qcom,spmi@` instead of basic `spmi@`.
I'm currently converting binding for
Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename
this and arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences
to `spmi@`.
Ideas, inputs?
Thank you
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node
2021-12-20 20:27 Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node David Heidelberg
@ 2021-12-21 7:12 ` Manivannan Sadhasivam
2021-12-22 9:19 ` Manivannan Sadhasivam
0 siblings, 1 reply; 4+ messages in thread
From: Manivannan Sadhasivam @ 2021-12-21 7:12 UTC (permalink / raw)
To: 20210106125322.61840-14-manivannan.sadhasivam
Cc: Rob Herring, Vinod Koul, linux-arm-msm, linux-kernel, agross,
bjorn.andersson
On Mon, Dec 20, 2021 at 09:27:17PM +0100, David Heidelberg wrote:
> Hello Manivannan,
>
> I'd like to ask, if you had any particular reason to name node `qcom,spmi@`
> instead of basic `spmi@`.
>
"spmi" node label was not documented by devicetree spec at that time. So I was
using "qcom,spmi" but it was not correct either.
I've submitted a PR now to devicetree-spec repo [1] for listing it as the
generic node name. So once it got accepted, we can use "spmi@" for the node
name.
Thanks,
Mani
[1] https://github.com/devicetree-org/devicetree-specification/pull/50
> I'm currently converting binding for
> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
> considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename this and
> arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences to `spmi@`.
>
> Ideas, inputs?
>
> Thank you
> David
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node
2021-12-21 7:12 ` Manivannan Sadhasivam
@ 2021-12-22 9:19 ` Manivannan Sadhasivam
2021-12-22 12:23 ` David Heidelberg
0 siblings, 1 reply; 4+ messages in thread
From: Manivannan Sadhasivam @ 2021-12-22 9:19 UTC (permalink / raw)
To: David Heidelberg
Cc: Rob Herring, Vinod Koul, linux-arm-msm, linux-kernel, agross,
bjorn.andersson
On Tue, Dec 21, 2021 at 12:42:25PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Dec 20, 2021 at 09:27:17PM +0100, David Heidelberg wrote:
> > Hello Manivannan,
> >
> > I'd like to ask, if you had any particular reason to name node `qcom,spmi@`
> > instead of basic `spmi@`.
> >
>
> "spmi" node label was not documented by devicetree spec at that time. So I was
> using "qcom,spmi" but it was not correct either.
>
> I've submitted a PR now to devicetree-spec repo [1] for listing it as the
> generic node name. So once it got accepted, we can use "spmi@" for the node
> name.
>
PR is merged now. So you can proceed with using "spmi" node name in all dts.
Thanks,
Mani
> Thanks,
> Mani
>
> [1] https://github.com/devicetree-org/devicetree-specification/pull/50
>
> > I'm currently converting binding for
> > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
> > considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename this and
> > arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences to `spmi@`.
> >
> > Ideas, inputs?
> >
> > Thank you
> > David
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node
2021-12-22 9:19 ` Manivannan Sadhasivam
@ 2021-12-22 12:23 ` David Heidelberg
0 siblings, 0 replies; 4+ messages in thread
From: David Heidelberg @ 2021-12-22 12:23 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Rob Herring, Vinod Koul, linux-arm-msm, linux-kernel, agross,
bjorn.andersson
Thank you.
I'll rename the nodes to `spmi@` then and send binding conversion.
David
PR is merged now. So you can proceed with using "spmi" node name in all dts.
Thanks,
Mani
> Thanks,
> Mani
>
> [1] https://github.com/devicetree-org/devicetree-specification/pull/50
>
> > I'm currently converting binding for
> > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
> > considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename this and
> > arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences to `spmi@`.
> >
> > Ideas, inputs?
> >
> > Thank you
> > David
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-22 12:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-20 20:27 Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node David Heidelberg
2021-12-21 7:12 ` Manivannan Sadhasivam
2021-12-22 9:19 ` Manivannan Sadhasivam
2021-12-22 12:23 ` David Heidelberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox