From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E138CC433FE for ; Thu, 23 Dec 2021 06:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242350AbhLWGew (ORCPT ); Thu, 23 Dec 2021 01:34:52 -0500 Received: from verein.lst.de ([213.95.11.211]:52790 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232444AbhLWGet (ORCPT ); Thu, 23 Dec 2021 01:34:49 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id D92A168AFE; Thu, 23 Dec 2021 07:34:46 +0100 (CET) Date: Thu, 23 Dec 2021 07:34:46 +0100 From: Christoph Hellwig To: Guenter Roeck Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Jackie Liu Subject: Re: [PATCH] scsi: bsg: Ignore bsg queue registration failures again Message-ID: <20211223063446.GA4005@lst.de> References: <20211222165427.1855582-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211222165427.1855582-1-linux@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 22, 2021 at 08:54:27AM -0800, Guenter Roeck wrote: > Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when > scsi_bsg_register_queue() fails"), errors from registering the bsg queue > are no longer ignored but returned to the caller. At the same time, the > comment in the code still states that errors are ignored. On top of that, > the message preporting the problem is printed as dev_info, not dev_err. > Both suggest that errors from bsg queue registrations should indeed be > ignored. But there is no good reason to ignore it. The proper fix is to fully handle the errors.