public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc: corbet@lwn.net, Jan Kara <jack@suse.cz>,
	"Darrick J. Wong" <djwong@kernel.org>,
	axboe@kernel.dk, "zhangyi (F)" <yi.zhang@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-doc@vger.kernel.org, linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] doc: fs: remove bdev_try_to_free_page related doc
Date: Thu, 23 Dec 2021 13:57:54 +0100	[thread overview]
Message-ID: <20211223125754.GC19129@quack2.suse.cz> (raw)
In-Reply-To: <c45e6351-b0f8-3410-787e-02c6aeb3efe6@huawei.com>

On Thu 23-12-21 11:51:00, Zhiqiang Liu wrote:
> 
> In commit acc6100d3ffa ("fs: remove bdev_try_to_free_page callback"),
> bdev_try_to_free_page has been removed.
> 
> We should remove its doc.
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>

Indeed. Thanks. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  Documentation/filesystems/locking.rst | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> index d36fe79167b3..3f9b1497ebb8 100644
> --- a/Documentation/filesystems/locking.rst
> +++ b/Documentation/filesystems/locking.rst
> @@ -169,7 +169,6 @@ prototypes::
>  	int (*show_options)(struct seq_file *, struct dentry *);
>  	ssize_t (*quota_read)(struct super_block *, int, char *, size_t, loff_t);
>  	ssize_t (*quota_write)(struct super_block *, int, const char *, size_t, loff_t);
> -	int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
> 
>  locking rules:
>  	All may block [not true, see below]
> @@ -194,7 +193,6 @@ umount_begin:		no
>  show_options:		no		(namespace_sem)
>  quota_read:		no		(see below)
>  quota_write:		no		(see below)
> -bdev_try_to_free_page:	no		(see below)
>  ======================	============	========================
> 
>  ->statfs() has s_umount (shared) when called by ustat(2) (native or
> @@ -210,9 +208,6 @@ dqio_sem) (unless an admin really wants to screw up something and
>  writes to quota files with quotas on). For other details about locking
>  see also dquot_operations section.
> 
> -->bdev_try_to_free_page is called from the ->releasepage handler of
> -the block device inode.  See there for more details.
> -
>  file_system_type
>  ================
> 
> -- 
> 2.23.0
> 
> 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2021-12-23 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23  3:51 [PATCH] doc: fs: remove bdev_try_to_free_page related doc Zhiqiang Liu
2021-12-23 12:57 ` Jan Kara [this message]
2021-12-23 14:15 ` Jens Axboe
2021-12-23 19:41   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211223125754.GC19129@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=djwong@kernel.org \
    --cc=linfeilong@huawei.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuzhiqiang26@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox