From: Jeffle Xu <jefflexu@linux.alibaba.com>
To: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com,
bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com,
gerry@linux.alibaba.com, eguan@linux.alibaba.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 13/23] erofs: implement fscache-based data read
Date: Mon, 27 Dec 2021 20:54:34 +0800 [thread overview]
Message-ID: <20211227125444.21187-14-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20211227125444.21187-1-jefflexu@linux.alibaba.com>
This patch implements the data plane of reading data from bootstrap blob
file over fscache.
Be noted that currently compressed layout is not supported yet.
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
fs/erofs/fscache.c | 91 +++++++++++++++++++++++++++++++++++++++++++++
fs/erofs/inode.c | 6 ++-
fs/erofs/internal.h | 1 +
3 files changed, 97 insertions(+), 1 deletion(-)
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 325f5663836b..bfcec831d58a 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -65,6 +65,97 @@ struct page *erofs_readpage_from_fscache(struct erofs_cookie_ctx *ctx,
return page;
}
+static inline void do_copy_page(struct page *from, struct page *to,
+ size_t offset, size_t len)
+{
+ char *vfrom, *vto;
+
+ vfrom = kmap_atomic(from);
+ vto = kmap_atomic(to);
+ memcpy(vto, vfrom + offset, len);
+ kunmap_atomic(vto);
+ kunmap_atomic(vfrom);
+}
+
+static int erofs_fscache_do_readpage(struct file *file, struct page *page)
+{
+ struct inode *inode = page->mapping->host;
+ struct erofs_inode *vi = EROFS_I(inode);
+ struct super_block *sb = inode->i_sb;
+ struct erofs_map_blocks map;
+ erofs_off_t o_la, pa;
+ size_t offset, len;
+ struct page *ipage;
+ int ret;
+
+ if (erofs_inode_is_data_compressed(vi->datalayout)) {
+ erofs_info(sb, "compressed layout not supported yet");
+ return -EOPNOTSUPP;
+ }
+
+ o_la = page_offset(page);
+ map.m_la = o_la;
+
+ ret = erofs_map_blocks(inode, &map, EROFS_GET_BLOCKS_RAW);
+ if (ret)
+ return ret;
+
+ if (!(map.m_flags & EROFS_MAP_MAPPED)) {
+ zero_user(page, 0, PAGE_SIZE);
+ return 0;
+ }
+
+ /*
+ * 1) For FLAT_PLAIN/FLAT_INLINE layout, the output map.m_la shall be
+ * equal to o_la, and the output map.m_pa is exactly the physical
+ * address of o_la.
+ * 2) For CHUNK_BASED layout, the output map.m_la is rounded down to the
+ * nearest chunk boundary, and the output map.m_pa is actually the
+ * physical address of this chunk boundary. So we need to recalculate
+ * the actual physical address of o_la.
+ */
+ pa = map.m_pa + o_la - map.m_la;
+
+ ipage = erofs_get_meta_page(sb, erofs_blknr(pa));
+ if (IS_ERR(ipage))
+ return PTR_ERR(ipage);
+
+ /*
+ * @offset refers to the page offset inside @ipage.
+ * 1) Except for the inline layout, the offset shall all be 0, and @pa
+ * shall be aligned with EROFS_BLKSIZ in this case. Thus we can
+ * conveniently get the offset from @pa.
+ * 2) While for the inline layout, the offset may be non-zero. Since
+ * currently only flat layout supports inline, we can calculate the
+ * offset from the corresponding physical address.
+ */
+ offset = erofs_blkoff(pa);
+ len = min_t(u64, map.m_llen, PAGE_SIZE);
+
+ do_copy_page(ipage, page, offset, len);
+
+ unlock_page(ipage);
+ return 0;
+}
+
+static int erofs_fscache_readpage(struct file *file, struct page *page)
+{
+ int ret;
+
+ ret = erofs_fscache_do_readpage(file, page);
+ if (ret)
+ SetPageError(page);
+ else
+ SetPageUptodate(page);
+
+ unlock_page(page);
+ return ret;
+}
+
+const struct address_space_operations erofs_fscache_access_aops = {
+ .readpage = erofs_fscache_readpage,
+};
+
static int erofs_fscache_init_cookie(struct erofs_cookie_ctx *ctx, char *path)
{
struct fscache_cookie *cookie;
diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c
index 2345f1de438e..452d147277c4 100644
--- a/fs/erofs/inode.c
+++ b/fs/erofs/inode.c
@@ -299,7 +299,11 @@ static int erofs_fill_inode(struct inode *inode, int isdir)
err = z_erofs_fill_inode(inode);
goto out_unlock;
}
- inode->i_mapping->a_ops = &erofs_raw_access_aops;
+
+ if (inode->i_sb->s_bdev)
+ inode->i_mapping->a_ops = &erofs_raw_access_aops;
+ else
+ inode->i_mapping->a_ops = &erofs_fscache_access_aops;
out_unlock:
unlock_page(page);
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index 10fb7ef26ddf..f3a1aa429a93 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -357,6 +357,7 @@ struct page *erofs_grab_cache_page_nowait(struct address_space *mapping,
extern const struct super_operations erofs_sops;
extern const struct address_space_operations erofs_raw_access_aops;
+extern const struct address_space_operations erofs_fscache_access_aops;
extern const struct address_space_operations z_erofs_aops;
/*
--
2.27.0
next prev parent reply other threads:[~2021-12-27 12:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 12:54 [PATCH v1 00/23] fscache,erofs: fscache-based demand-read semantics Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 01/23] cachefiles: add cachefiles_demand devnode Jeffle Xu
2021-12-28 2:47 ` Joseph Qi
2021-12-28 12:34 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 02/23] cachefiles: add mode command to distinguish modes Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 03/23] cachefiles: detect backing file size in demand-read mode Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 04/23] netfs: make ops->init_rreq() optional Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 05/23] netfs: add inode parameter to netfs_alloc_read_request() Jeffle Xu
2022-01-04 14:00 ` Gao Xiang
2022-01-13 3:10 ` [Linux-cachefs] " JeffleXu
2022-01-13 12:09 ` Gao Xiang
2021-12-27 12:54 ` [PATCH v1 06/23] erofs: export erofs_map_blocks() Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 07/23] erofs: add nodev mode Jeffle Xu
2022-01-04 14:33 ` Gao Xiang
2022-01-04 14:58 ` Gao Xiang
2022-01-05 9:04 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 08/23] erofs: register global fscache volume Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 09/23] erofs: add cookie context helper functions Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 10/23] erofs: add anonymous inode managing page cache of blob file Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 11/23] erofs: register cookie context for bootstrap Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 12/23] erofs: implement fscache-based metadata read Jeffle Xu
2021-12-27 12:54 ` Jeffle Xu [this message]
2022-01-03 6:32 ` [PATCH v1 13/23] erofs: implement fscache-based data read JeffleXu
2022-01-04 14:40 ` Gao Xiang
2022-01-05 2:29 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 14/23] erofs: register cookie context for data blobs Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 15/23] erofs: implement fscache-based data read " Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 16/23] erofs: add 'uuid' mount option Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 17/23] netfs: support on demand read Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 18/23] cachefiles: use idr tree managing pending " Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 19/23] cachefiles: implement .demand_read() for " Jeffle Xu
2021-12-27 15:36 ` Matthew Wilcox
2021-12-28 12:33 ` JeffleXu
2022-01-12 9:02 ` JeffleXu
2022-01-19 13:20 ` Matthew Wilcox
2022-01-20 12:43 ` JeffleXu
2021-12-27 12:54 ` [PATCH v1 20/23] cachefiles: implement .poll() " Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 21/23] cachefiles: implement .read() " Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 22/23] cachefiles: add done command " Jeffle Xu
2021-12-27 12:54 ` [PATCH v1 23/23] erofs: support on " Jeffle Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211227125444.21187-14-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=bo.liu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=dhowells@redhat.com \
--cc=eguan@linux.alibaba.com \
--cc=gerry@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tao.peng@linux.alibaba.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox