From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Miquel Raynal <miquel.raynal@bootlin.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: [mtd:spi-mem-ecc 14/16] drivers/mtd/nand/ecc-mxic.c:395 mxic_ecc_data_xfer_wait_for_completion() error: uninitialized symbol 'val'.
Date: Thu, 6 Jan 2022 11:54:51 +0300 [thread overview]
Message-ID: <202112271621.cNxEVvN6-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-mem-ecc
head: 5966bd4f59edbbe5873b1b4637ed50f258ced0b2
commit: b78baf1891f0b7c3f0e2e3e6022eab38ee6c871f [14/16] mtd: nand: mxic-ecc: Add Macronix external ECC engine support
config: i386-randconfig-m021-20211227 (https://download.01.org/0day-ci/archive/20211227/202112271621.cNxEVvN6-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/mtd/nand/ecc-mxic.c:395 mxic_ecc_data_xfer_wait_for_completion() error: uninitialized symbol 'val'.
drivers/mtd/nand/ecc-mxic.c:548 mxic_ecc_prepare_io_req_external() error: uninitialized symbol 'ret'.
vim +/val +395 drivers/mtd/nand/ecc-mxic.c
b78baf1891f0b7 Miquel Raynal 2021-12-16 377 static int mxic_ecc_data_xfer_wait_for_completion(struct mxic_ecc_engine *mxic)
b78baf1891f0b7 Miquel Raynal 2021-12-16 378 {
b78baf1891f0b7 Miquel Raynal 2021-12-16 379 u32 val;
b78baf1891f0b7 Miquel Raynal 2021-12-16 380 int ret;
b78baf1891f0b7 Miquel Raynal 2021-12-16 381
b78baf1891f0b7 Miquel Raynal 2021-12-16 382 if (mxic->irq) {
b78baf1891f0b7 Miquel Raynal 2021-12-16 383 reinit_completion(&mxic->complete);
b78baf1891f0b7 Miquel Raynal 2021-12-16 384 mxic_ecc_enable_int(mxic);
b78baf1891f0b7 Miquel Raynal 2021-12-16 385 ret = wait_for_completion_timeout(&mxic->complete,
b78baf1891f0b7 Miquel Raynal 2021-12-16 386 msecs_to_jiffies(1000));
b78baf1891f0b7 Miquel Raynal 2021-12-16 387 mxic_ecc_disable_int(mxic);
"val" not set on this path.
b78baf1891f0b7 Miquel Raynal 2021-12-16 388 } else {
b78baf1891f0b7 Miquel Raynal 2021-12-16 389 ret = readl_poll_timeout(mxic->regs + INTRPT_STS, val,
b78baf1891f0b7 Miquel Raynal 2021-12-16 390 val & TRANS_CMPLT, 10, USEC_PER_SEC);
b78baf1891f0b7 Miquel Raynal 2021-12-16 391 writel(val, mxic->regs + INTRPT_STS);
b78baf1891f0b7 Miquel Raynal 2021-12-16 392 }
b78baf1891f0b7 Miquel Raynal 2021-12-16 393
b78baf1891f0b7 Miquel Raynal 2021-12-16 394 if (ret) {
b78baf1891f0b7 Miquel Raynal 2021-12-16 @395 dev_err(mxic->dev, "Timeout on data xfer completion (sts 0x%08x)\n", val);
^^^
b78baf1891f0b7 Miquel Raynal 2021-12-16 396 return -ETIMEDOUT;
b78baf1891f0b7 Miquel Raynal 2021-12-16 397 }
b78baf1891f0b7 Miquel Raynal 2021-12-16 398
b78baf1891f0b7 Miquel Raynal 2021-12-16 399 return 0;
b78baf1891f0b7 Miquel Raynal 2021-12-16 400 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2022-01-06 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 8:54 Dan Carpenter [this message]
2022-01-26 10:49 ` [mtd:spi-mem-ecc 14/16] drivers/mtd/nand/ecc-mxic.c:395 mxic_ecc_data_xfer_wait_for_completion() error: uninitialized symbol 'val' Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112271621.cNxEVvN6-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox