Re: [PATCH v2] phy: mapphone-mdm6600: Fix PM error handling in phy_mdm6600_probe

Vinod Koul
2022-04-13T10:55:02Z

On 01-03-22, 02:46, Miaoqian Lin wrote:
> The pm_runtime_enable will increase power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable(). And use pm_runtime_dont_use_autosuspend() to
> undo pm_runtime_use_autosuspend()
> In the PM Runtime docs:
> Drivers in ->remove() callback should undo the runtime PM changes done
> in ->probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc.
>
> We should do this in error handling.

Applied, thanks

--
~Vinod