Re: [PATCH] staging: pi433: move get version func to where all other functions are

Paulo Miguel Almeida
2022-01-07T18:45:49Z

On Fri, Jan 07, 2022 at 11:32:58AM +0300, Dan Carpenter wrote:
> > Additionally, the patch below must be applied first as it was sent
> > before and touches the same file.
> > https://lore.kernel.org/lkml/20220103222334.GA6814@mail.google.com/
>
> Put these sorts of meta commentary underneath the --- cut off

Thanks, I didn't know. Will start doing this from now onwards

> >
> > Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> > ---
> ^^^
>
> here. We don't need to preserve that information in the git log for all
> of history.
>
> Other people have basically said all the other stuff that I was going
> to say...
>
> regards,
> dan carpenter
>