From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alex Elder <elder@ieee.org>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: audio: Check null pointer
Date: Thu, 6 Jan 2022 13:27:33 +0300 [thread overview]
Message-ID: <20220106102733.GK7674@kadam> (raw)
In-Reply-To: <2410da25-5f91-dd4c-77d0-b7226b56616d@ieee.org>
On Tue, Dec 28, 2021 at 08:50:22AM -0600, Alex Elder wrote:
>
> There is a chance that your simple return would "work"
No. Your original comment was correct. It has to "ret = -ENOMEM;
goto error;"
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-06 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 2:02 Re: [PATCH] staging: greybus: audio: Check null pointer Jiasheng Jiang
2021-12-28 14:50 ` Alex Elder
2022-01-06 10:27 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-24 9:03 Jiasheng Jiang
2021-12-27 15:54 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106102733.GK7674@kadam \
--to=dan.carpenter@oracle.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jiasheng@iscas.ac.cn \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox