Re: [PATCH linux] ext4: Delete useless ret assignment

Theodore Ts'o
2022-01-06T04:44:47Z

On Thu, Dec 30, 2021 at 06:29:05AM +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
>
> The assignments in these two places will be overwritten by new
> assignments later, so they should be deleted.
>
> The clang_analyzer complains as follows:
>
> fs/ext4/fast_commit.c
>
> Value stored to 'ret' is never read

I suspect the right answer here is that we *should* be checking the
return value, and reflecting the error up to caller, if appropriate.

Harshad, what do you think?

- Ted

>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
> ---
> fs/ext4/fast_commit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index 8ea5a81..8d5d044 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -1660,7 +1660,7 @@ static int ext4_fc_replay_add_range(struct super_block *sb,
> return 0;
> }
>
> - ret = ext4_fc_record_modified_inode(sb, inode->i_ino);
> + ext4_fc_record_modified_inode(sb, inode->i_ino);
>
> start = le32_to_cpu(ex->ee_block);
> start_pblk = ext4_ext_pblock(ex);
> @@ -1785,7 +1785,7 @@ ext4_fc_replay_del_range(struct super_block *sb, struct ext4_fc_tl *tl,
> return 0;
> }
>
> - ret = ext4_fc_record_modified_inode(sb, inode->i_ino);
> + ext4_fc_record_modified_inode(sb, inode->i_ino);
>
> jbd_debug(1, "DEL_RANGE, inode %ld, lblk %d, len %d\n",
> inode->i_ino, le32_to_cpu(lrange.fc_lblk),
> --
> 2.15.2
>
>