Re: [PATCH] staging: pi433: move get version func to where all other functions are

Dan Carpenter
2022-01-07T08:33:33Z

On Thu, Jan 06, 2022 at 10:31:10PM +1300, Paulo Miguel Almeida wrote:
> As a convention for the pi433 driver, all routines that deals with the
> rf69 chip are defined in the rf69.c file. There was an exception in
> which the uC version verification was being done directly elsewhere.
> While at it, the Version Register hardcoded value was replaced with a
> pre-existing constant in the driver.
>
> This patch adds rf69_get_chip_version function to rf69.c
>
> Additionally, the patch below must be applied first as it was sent
> before and touches the same file.
> https://lore.kernel.org/lkml/20220103222334.GA6814@mail.google.com/

Put these sorts of meta commentary underneath the --- cut off

>
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
^^^

here. We don't need to preserve that information in the git log for all
of history.

Other people have basically said all the other stuff that I was going
to say...

regards,
dan carpenter