Re: [PATCH 1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC

Eugene Shalygin
2022-01-11T17:22:22Z

> I do not see the point of marking this as doc strings
…
> and neither this one, nor anywhere else where "**" is used.
> The resulting "documentation" is just confusing and provides no value.

My editor shows nice tooltips for /** comments and I did not realise
kernel doc processes
all the source unconditionally. Anyway, I removed them.

> Why not just "sensors" directly ? Is there ever going to be anything else ?
> If not, the value could be added to the dmi array directly without pointer
> indirection.

I once had an ASUS board where they changed board headers in some
hardware revision. I suspect the EC sensors
interface is valid for their other boards too, we just need users to
collect those data. It's quite possible that the DMI
board version would change in that case, so that we can add another
DMI match if required.
So, I'll take your advice and move the sensors to the driver_data field.

> FWIW, MODULE_VERSION tends to have zero value since it tends to end up
> not being updated.

Setting the value to 0 then :)

Best regards,
Eugene