* [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon @ 2022-01-13 7:11 Yang Li 2022-01-13 7:11 ` [PATCH -next 2/2 v2] drm/amdgpu: clean up some inconsistent indenting Yang Li 2022-01-13 13:38 ` [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Chen, Guchun 0 siblings, 2 replies; 4+ messages in thread From: Yang Li @ 2022-01-13 7:11 UTC (permalink / raw) To: airlied, Guchun.Chen Cc: daniel, alexander.deucher, christian.koenig, Xinhui.Pan, amd-gfx, dri-devel, linux-kernel, Yang Li, Abaci Robot Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2725:16-17: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index d4d9b9ea8bbd..ff9bd5a844fe 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -2722,7 +2722,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev) int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con) { if (!adev) - return -EINVAL;; + return -EINVAL; adev->psp.ras_context.ras = ras_con; return 0; -- 2.20.1.7.g153144c ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next 2/2 v2] drm/amdgpu: clean up some inconsistent indenting 2022-01-13 7:11 [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Yang Li @ 2022-01-13 7:11 ` Yang Li 2022-01-13 13:38 ` [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Chen, Guchun 1 sibling, 0 replies; 4+ messages in thread From: Yang Li @ 2022-01-13 7:11 UTC (permalink / raw) To: airlied, Guchun.Chen Cc: daniel, alexander.deucher, christian.koenig, Xinhui.Pan, amd-gfx, dri-devel, linux-kernel, Yang Li, Abaci Robot Eliminate the follow smatch warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3504 amdgpu_device_init() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1716 amdgpu_ras_error_status_query() warn: if statement not indented drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1058 amdgpu_ras_error_inject() warn: inconsistent indenting Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 33388041c354..64d6c0af4c76 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -3499,7 +3499,7 @@ int amdgpu_device_init(struct amdgpu_device *adev, mutex_init(&adev->notifier_lock); mutex_init(&adev->pm.stable_pstate_ctx_lock); - amdgpu_device_init_apu_flags(adev); + amdgpu_device_init_apu_flags(adev); r = amdgpu_device_check_arguments(adev); if (r) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index ff9bd5a844fe..6d84749698c8 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -1055,8 +1055,10 @@ int amdgpu_ras_error_inject(struct amdgpu_device *adev, .address = info->address, .value = info->value, }; - int ret = -EINVAL; - struct amdgpu_ras_block_object* block_obj = amdgpu_ras_get_ras_block(adev, info->head.block, info->head.sub_block_index); + int ret = -EINVAL; + struct amdgpu_ras_block_object *block_obj = amdgpu_ras_get_ras_block(adev, + info->head.block, + info->head.sub_block_index); if (!obj) return -EINVAL; @@ -1714,7 +1716,7 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev, } if (block_obj->hw_ops->query_ras_error_status) - block_obj->hw_ops->query_ras_error_status(adev); + block_obj->hw_ops->query_ras_error_status(adev); } -- 2.20.1.7.g153144c ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon 2022-01-13 7:11 [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Yang Li 2022-01-13 7:11 ` [PATCH -next 2/2 v2] drm/amdgpu: clean up some inconsistent indenting Yang Li @ 2022-01-13 13:38 ` Chen, Guchun 2022-01-13 18:28 ` Alex Deucher 1 sibling, 1 reply; 4+ messages in thread From: Chen, Guchun @ 2022-01-13 13:38 UTC (permalink / raw) To: Yang Li, airlied@linux.ie Cc: daniel@ffwll.ch, Deucher, Alexander, Koenig, Christian, Pan, Xinhui, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abaci Robot Series is: Reviewed-by: Guchun Chen <guchun.chen@amd.com> Regards, Guchun -----Original Message----- From: Yang Li <yang.lee@linux.alibaba.com> Sent: Thursday, January 13, 2022 3:12 PM To: airlied@linux.ie; Chen, Guchun <Guchun.Chen@amd.com> Cc: daniel@ffwll.ch; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Yang Li <yang.lee@linux.alibaba.com>; Abaci Robot <abaci@linux.alibaba.com> Subject: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2725:16-17: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index d4d9b9ea8bbd..ff9bd5a844fe 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -2722,7 +2722,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev) int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con) { if (!adev) - return -EINVAL;; + return -EINVAL; adev->psp.ras_context.ras = ras_con; return 0; -- 2.20.1.7.g153144c ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon 2022-01-13 13:38 ` [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Chen, Guchun @ 2022-01-13 18:28 ` Alex Deucher 0 siblings, 0 replies; 4+ messages in thread From: Alex Deucher @ 2022-01-13 18:28 UTC (permalink / raw) To: Chen, Guchun Cc: Yang Li, airlied@linux.ie, Pan, Xinhui, Abaci Robot, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Deucher, Alexander, Koenig, Christian Applied. Thanks! Alex On Thu, Jan 13, 2022 at 8:38 AM Chen, Guchun <Guchun.Chen@amd.com> wrote: > > Series is: > Reviewed-by: Guchun Chen <guchun.chen@amd.com> > > Regards, > Guchun > > -----Original Message----- > From: Yang Li <yang.lee@linux.alibaba.com> > Sent: Thursday, January 13, 2022 3:12 PM > To: airlied@linux.ie; Chen, Guchun <Guchun.Chen@amd.com> > Cc: daniel@ffwll.ch; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Yang Li <yang.lee@linux.alibaba.com>; Abaci Robot <abaci@linux.alibaba.com> > Subject: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon > > Eliminate the following coccicheck warning: > ./drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2725:16-17: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > index d4d9b9ea8bbd..ff9bd5a844fe 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > @@ -2722,7 +2722,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev) int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con) { > if (!adev) > - return -EINVAL;; > + return -EINVAL; > > adev->psp.ras_context.ras = ras_con; > return 0; > -- > 2.20.1.7.g153144c > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-13 18:28 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-01-13 7:11 [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Yang Li 2022-01-13 7:11 ` [PATCH -next 2/2 v2] drm/amdgpu: clean up some inconsistent indenting Yang Li 2022-01-13 13:38 ` [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon Chen, Guchun 2022-01-13 18:28 ` Alex Deucher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox